Mark JSPointerDispatcher and JSTouchDispatcher as open (#57022)#57022
Closed
cortinico wants to merge 1 commit into
Closed
Mark JSPointerDispatcher and JSTouchDispatcher as open (#57022)#57022cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D107089429. |
This was referenced Jun 1, 2026
Summary: The Java-to-Kotlin migration of these classes made them implicitly final (Kotlin default), breaking downstream libraries that subclass them (e.g. react-native-keyboard-controller's JSPointerDispatcherCompat). Adding `open` restores the pre-migration extensibility. ## Changelog: [ANDROID] [CHANGED] - Mark JSPointerDispatcher and JSTouchDispatcher as open Test Plan: CI Reviewed By: javache Differential Revision: D107089429 Pulled By: cortinico
meta-codesync
Bot
changed the title
meta-codesync
Bot
force-pushed
the
nc/fix-nightly
branch
from
6f77ed6 to
e1a43b7
Compare
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107089429. |
kirillzyusko
pushed a commit
to kirillzyusko/react-native-keyboard-controller
that referenced
this pull request
Jun 1, 2026
## 📜 Description JSPointerDispatcher became a final Kotlin class in React Native 0.87+ (after the Java-to-Kotlin migration in facebook/react-native#56910), so JSPointerDispatcherCompat can no longer extend it. While I'm restoring it in: - facebook/react-native#57022 Ideally we would want to reduce the API surface of RN apis. So here I'm switching from inheritance to composition by holding an internal JSPointerDispatcher delegate and forwarding calls to it. ## 🤔 How Has This Been Tested? Looking for guidance on how to test this. <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> ## 📸 Screenshots (if appropriate): N/A <!-- Add screenshots/video if needed --> <!-- That would be highly appreciated if you can add how it looked before and after your changes --> ## 📝 Checklist - [ ] CI successfully passed - [ ] I added new mocks and corresponding unit-tests if library API was changed
Contributor
Author
|
Abandoning as no longer needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The Java-to-Kotlin migration of these classes made them implicitly final (Kotlin default), breaking downstream libraries that subclass them (e.g. react-native-keyboard-controller's JSPointerDispatcherCompat).
Adding
openrestores the pre-migration extensibility.Changelog:
[ANDROID] [CHANGED] - Mark JSPointerDispatcher and JSTouchDispatcher as open
Test Plan: CI
Reviewed By: javache
Differential Revision: D107089429
Pulled By: cortinico