Update folly hash for 11.7 release - #14949
Open
anand1976 wants to merge 1 commit into
Open
Conversation
✅ clang-tidy: No findings on changed linesCompleted in 0.0s. |
✅ Claude Code ReviewAuto-triggered after CI passed — reviewing commit be3ee98 SummaryTrivial dependency bump: updates No high-severity findings. Full review (click to expand)Findings🔴 HIGHNone. 🟡 MEDIUMNone. 🟢 LOW / NITL1. Post-checkout patches may need updating —
|
| Context | Affected? | Notes |
|---|---|---|
USE_FOLLY=1 build |
Yes | Will checkout and build the new folly commit |
USE_FOLLY_LITE=1 build |
Indirectly | Uses third-party/folly source checked out at this hash |
| Default build (no folly) | No | FOLLY_COMMIT_HASH is defined but never used |
| BUCK / CMake builds | No | Variable is only in folly.mk |
Positive Observations
- The hash is a valid 40-character lowercase hex SHA-1, consistent with the expected format.
- The PR description clearly states this is part of the 11.7 release workflow and provides context for the bump.
- Pinning to a specific commit (rather than tracking
main) is the correct approach for CI stability.
ℹ️ About this response
Generated by Claude Code.
Review methodology: claude_md/code_review.md
Limitations:
- Claude may miss context from files not in the diff
- Large PRs may be truncated
- Always apply human judgment to AI suggestions
Commands:
/claude-review [context]— Request a code review/claude-query <question>— Ask about the PR or codebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
folly.mkFOLLY_COMMIT_HASH to d1f69a7974fcThis is folly's
mainat release-cut time. Review and merge to take the bump, or close to skip folly for this release.Part of 11.7 release workflow.