Release TransactionDB path string after multi-CF open - #14976
Open
verma-divyanshu-git wants to merge 1 commit into
Open
Release TransactionDB path string after multi-CF open#14976verma-divyanshu-git wants to merge 1 commit into
verma-divyanshu-git wants to merge 1 commit into
Conversation
Author
|
@adamretter Would you be able to review this small RocksJava JNI resource-lifetime fix, or point me to the appropriate reviewer? It follows the existing release pattern in the single-column-family and @K-ANOY, this addresses the leak reported in #14893; any verification would be appreciated. |
|
Looks good to me. This fixes the reported leak. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release the database path returned by
GetStringUTFCharsafter the multi-column-familyTransactionDB::Opencall.This matches the resource handling in the single-column-family and
OptimisticTransactionDBimplementations.Fixes #14893
Test plan
TransactionDBTestwith-Xcheck:jni: 11 tests passed.leaksand confirmed the originalGetStringUTFCharsleak stack is no longer present.make check-formatandgit diff --check.