This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Fix Issue Where Thrash Tester Would Throw Exceptions During Other Tests#2800
Merged
Adlai-Holler merged 1 commit intomasterfrom Dec 19, 2016
Merged
Fix Issue Where Thrash Tester Would Throw Exceptions During Other Tests#2800Adlai-Holler merged 1 commit intomasterfrom
Adlai-Holler merged 1 commit intomasterfrom
Conversation
Contributor
Author
|
It's not important that this is landed before or after the 2.0.1 release, since it doesn't touch public-facing code in a significant way. |
Adlai-Holler
force-pushed
the
AHThrashTestFailReliably
branch
from
1970dbf to
5d97934
Compare
…d to avoid polluting other tests
Adlai-Holler
force-pushed
the
AHThrashTestFailReliably
branch
from
5d97934 to
ffc15c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC #2436 #2203 #2658
This diff ensures that all cell nodes are deallocated before the thrash test method returns.
We now have another good test case for cell node visibility issues linked above. Unfortunately, that test case is currently failing, so the test has to remain disabled.