You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Motivation and Context / Related issue
How Has This Been Tested (if it applies)
@teytaud the aim is to make the use of nevergrad simpler by only providing the main variantsof the optimizers.
All other optimizers can be created straightforwardly using the ng.families.DifferentialEvolution and other configurable classes.
On the other and, for the experiments, all variants are loaded
Checklist
The documentation is up-to-date with the changes I made.
I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
All tests passed, and additional code has been covered with new tests.
The reason will be displayed to describe this comment to others. Learn more.
if I understand correctly, this is moving, not breaking, so imho just go ahead and we'll see in the long run if we fill that some algorithms should be moved elsewhere.
if I understand correctly, this is moving, not breaking, so imho just go ahead and we'll see in the long run if we fill that some algorithms should be moved elsewhere.
It's partially breaking: all the optimizers in experimentalvariants wont be available in ng.optimizers, and will only be registered in the optimizers registry if they explicitly import the module beforehand.
This is to avoid people getting lost with hundreds of variants and not knowing which one to use. Eventually we want to keep only the most important variants available, and promote the configured optimizers (with nice docstrings) so they can build the variants on their own that perfectly meet their needs
jrapin
changed the title
[TO BE DISCUSSED] Gather experimental variants together
Gather experimental variants together
Feb 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA SignedDo not delete this pull request or issue due to inactivity.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and Context / Related issue
How Has This Been Tested (if it applies)
@teytaud the aim is to make the use of nevergrad simpler by only providing the main variantsof the optimizers.
All other optimizers can be created straightforwardly using the ng.families.DifferentialEvolution and other configurable classes.
On the other and, for the experiments, all variants are loaded
Checklist