check suggest - #635
Merged
Merged
Conversation
facebook-github-bot
added
the
CLA Signed
jrapin
reviewed
May 4, 2020
| optimizer.tell(candidate, 12) | ||
| # The optimizer should recommend its suggestion, except for a few optimization methods: | ||
| if name not in ["SPSA", "TBPSA", "StupidRandom"]: | ||
| np.testing.assert_array_almost_equal(optimizer.provide_recommendation().args[0], [12.0] * 4) |
Contributor
There was a problem hiding this comment.
you should use parameter.value here instead of args[0] which is not as clear
jrapin
approved these changes
May 5, 2020
teytaud
added a commit
that referenced
this pull request
May 25, 2020
teytaud
added a commit
that referenced
this pull request
May 25, 2020
* firstMetaModel * meta_model_for_shiva * fix * Type_fix:_.value_was_missing. Also better handling of exceptions. * Tell not asked: I'm lost. * Add recommendation. * Add recommendation. * Let us catch bad big values in metamodels. * Deactivate BO test for windows * Add metamodel in illcond tests. * fixstaticanalysis * Update optimizerlib.py * updateMetaModel (#692) * updateMetaModel * Update optimizerlib.py * Check suggest recommendation (#635) * Add basic Pylint tests (#669) * Allow repetitions for Choice parameters (#670) * firstMetaModel * meta_model_for_shiva * Update post version number * Fix repeated Choice hash (#676) * fix * Type_fix:_.value_was_missing. Also better handling of exceptions. * Tell not asked: I'm lost. * Add recommendation. * Add recommendation. * Let us catch bad big values in metamodels. * Deactivate BO test for windows * Add metamodel in illcond tests. * fixstaticanalysis * Lazy initialization in MLTuning (#673) * Fix discrete mutation in dim 1 (#679) Co-authored-by: Jeremy Rapin <jrapin@fb.com> Co-authored-by: Teytaud <oteytaud@fb.com> * fix * Add an experimental bouncing bounding method (#684) * Add a tutorial for windows users (#688) * Update optimizerlib.py * updateMetaModel (#692) * updateMetaModel * Update optimizerlib.py Co-authored-by: Jeremy Rapin <jrapin@fb.com> Co-authored-by: Jérémy Rapin <jrapin.github@gmail.com> Co-authored-by: Fabien Teytaud <teytaud@lisic.univ-littoral.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and Context / Related issue
Checking if suggest is not ignored.
How Has This Been Tested (if it applies)
CI
Checklist