Make bouncing the default for constraints - #691
Merged
Conversation
teytaud
approved these changes
May 25, 2020
teytaud
left a comment
Contributor
There was a problem hiding this comment.
Do I understand correctly that bouncing is tested once and then clipping is applied ?
Contributor
Author
What do you mean tested once?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and Context / Related issue
This is a follow-up of #684 making
bouncingthe default for bounding constraints. Hard clipping on the bounds can lead to very detrimental loss of diversity. Bouncing on the border can help avoid this in being closer to an actual constraint through resampling, while being much more efficient in large dimensionCloses #621
How Has This Been Tested (if it applies)
Checklist