Skip to content

Conversation

@afragen
Copy link
Contributor

@afragen afragen commented Jul 15, 2025

Add WP Core's compat.php for backwards PHP compatibility.

Fixes #163

Signed-off-by: Andy Fragen <andy@thefragens.com>
@afragen afragen requested review from Ipstenu, costdev and rmccue July 15, 2025 15:32
@afragen afragen added 3rd party For external APIs and services (like AspirePress/Cloud, caching, etc) compatibility-issue Compatibility issue with some other plugin, theme, or environment labels Jul 15, 2025
@afragen
Copy link
Contributor Author

afragen commented Jul 15, 2025

Coding standards CI failure is fixed in other PRs.

afragen added 3 commits July 15, 2025 08:47
Signed-off-by: Andy Fragen <andy@thefragens.com>
Signed-off-by: Andy Fragen <andy@thefragens.com>
This reverts commit 64f6beb.
Signed-off-by: Andy Fragen <andy@thefragens.com>
Signed-off-by: Andy Fragen <andy@thefragens.com>
@afragen
Copy link
Contributor Author

afragen commented Jul 15, 2025

Unfortunately this was not just a simple drop-in. I needed to add more ! function_exists() logic.

Copy link
Member

@costdev costdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We can also now update every strpos() call that related to contains, starts with, or ends with. 🎉

@afragen
Copy link
Contributor Author

afragen commented Jul 15, 2025

Tag, you're it for that.

@costdev costdev merged commit 2b858dc into fairpm:main Jul 15, 2025
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3rd party For external APIs and services (like AspirePress/Cloud, caching, etc) compatibility-issue Compatibility issue with some other plugin, theme, or environment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add WP polyfills for backwards PHP compatibility

2 participants