Change from wp_cache_* to *_transient for fair-plugin #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Fragen <andy@thefragens.com>
costdev
reviewed
Sep 9, 2025
Member
There was a problem hiding this comment.
Just left a question about prefixing the transient since the cache group isn't there anymore.
More generally, it'd be nice to standardize the constants for cache prefixes for these at some point with consistent naming and where they're defined with something like:
// inc/namespace.php
const CACHE_BASE = 'fair-';
const CACHE_LIFETIME = 12 * HOUR_IN_SECONDS;
// inc/packages/namespace.php
use const FAIR\CACHE_BASE;
const CACHE_METADATA_ENDPOINTS = CACHE_BASE . 'metadata-endpoints-';
const CACHE_METADATA_DOCUMENTS = CACHE_BASE . 'metadata-documents-';
const CACHE_RELEASE_PACKAGES = CACHE_BASE . 'release-packages-';
inc/packages/namespace.php
Outdated
| return $document; | ||
| } | ||
| wp_cache_set( $id, $document, 'did-docs', CACHE_LIFETIME ); | ||
| set_transient( $id, $document, CACHE_LIFETIME ); |
Member
There was a problem hiding this comment.
Should the transient names be prefixed since we don't have the cache group anymore?
Contributor
Author
|
Seems like something for another PR unless you want me to update here? |
Signed-off-by: Andy Fragen <andy@thefragens.com>
costdev
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use transients not wp_cache_* for fair-plugin