-
-
Notifications
You must be signed in to change notification settings - Fork 638
Release 1.8.0 #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release 1.8.0 #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update information on different platforms
[NtQueryInformationProcess](https://learn.microsoft.com/en-us/windows/win32/api/winternl/nf-winternl-ntqueryinformationprocess) is an internal NT syscall which may change in the future. However, unlike other NT syscalls NtQueryInformationProcess is well documented on MSDN, so I think it's safe to use. Boost shell detection by 0.3s on my machine. Note querying PowerShell's version `pwsh --version` costs another 0.2s
…version of pwsh.exe file Also add cmd version detection
Completely untested
TerminalShell: improve speed on Windows
Add Garuda small variant
According to MSDN, GetVersionExA is not reliable. We have to query WMI instead.
by making C++ code more C++
Windows: fix kernel detection; simplify WMI query code
Work/disk refactor
fix ASAN warning: `runtime error: nan is outside the range of representable values of type 'unsigned char'`
1. Since swap module is disabled by default, swap detection is unnecessary in most cases. 2. On platform other than Linux, swap detection doesn't share code with memory. 3. Swap detection can be expensive. On Windows, it requires another WMI query which can lag heavily in some cases. Don't pay for you don't use.
Disk: add volume name detection; don't print 0B / 0B (0%)
Swap: split code out from memory detection
Add Univalent GNU/Linux's logo
Update help.txt
iTerm image protocol supports most commonly used image formats so we don't need image magick to convert image format. However, since we don't know anything about the image, `--logo-width` `--logo-height` must be specified to make sure that logo will not be covered by texts.
Spelling and grammer fixes
It's only supported on Linux
My fault
... which is Linux specific
We can't do the same thing with memory because there is no `cachedram` in `struct sysinfo`
LinusDierheimer
approved these changes
Dec 28, 2022
Collaborator
LinusDierheimer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did great work, lets release it!
Collaborator
|
@CarterLi This was supposed to create a release, right? Then we need to increase the version in CMakeLists.txt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan to release a new version before 2023
Todo list:
Add to package managers:
Update build scripts:
vulkan-headersvulkan-loader-androidfreetypeimagemagickchafacjsonvulkan-loaderopencl-icdCloses #359 #320
@LinusDierheimer Please review!