Skip to content

Conversation

@CarterLi
Copy link
Member

@CarterLi CarterLi commented Dec 28, 2022

I plan to release a new version before 2023

Todo list:

Add to package managers:

  1. Scoop
  2. Choco
  3. MSYS2-MinGW / pacman ( not MSYS2-Msys )
  4. pkg

Update build scripts:

  1. Build dependency for Android (Termux): vulkan-headers vulkan-loader-android freetype
  2. Build dependency for macOS (Brew): imagemagick chafa
  3. Build dependency for Windows (MSYS2-MinGW / pacman): cjson vulkan-loader opencl-icd

Closes #359 #320

@LinusDierheimer Please review!

CarterLi and others added 30 commits October 15, 2022 11:36
Update information on different platforms
[NtQueryInformationProcess](https://learn.microsoft.com/en-us/windows/win32/api/winternl/nf-winternl-ntqueryinformationprocess) is an internal NT syscall which may change in the future. However, unlike other NT syscalls NtQueryInformationProcess is well documented on MSDN, so I think it's safe to use.

Boost shell detection by 0.3s on my machine. Note querying PowerShell's version `pwsh --version` costs another 0.2s
…version of pwsh.exe file

Also add cmd version detection
TerminalShell: improve speed on Windows
Add Garuda small variant
According to MSDN, GetVersionExA is not reliable. We have to query WMI instead.
by making C++ code more C++
Windows: fix kernel detection; simplify WMI query code
fix ASAN warning: `runtime error: nan is outside the range of representable values of type 'unsigned char'`
1. Since swap module is disabled by default, swap detection is unnecessary in most cases.
2. On platform other than Linux, swap detection doesn't share code with memory.
3. Swap detection can be expensive. On Windows, it requires another WMI query which can lag heavily in some cases. Don't pay for you don't use.
Disk: add volume name detection; don't print 0B / 0B (0%)
Swap: split code out from memory detection
Add Univalent GNU/Linux's logo
CarterLi and others added 26 commits December 22, 2022 02:40
iTerm image protocol supports most commonly used image formats so we don't need image magick to convert image format.
However, since we don't know anything about the image, `--logo-width` `--logo-height` must be specified to make sure that logo will not be covered by texts.
Spelling and grammer fixes
It's only supported on Linux
... which is Linux specific
We can't do the same thing with memory because there is no `cachedram` in `struct sysinfo`
Copy link
Collaborator

@LinusDierheimer LinusDierheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did great work, lets release it!

@LinusDierheimer LinusDierheimer merged commit f2bae20 into master Dec 28, 2022
@LinusDierheimer
Copy link
Collaborator

@CarterLi This was supposed to create a release, right? Then we need to increase the version in CMakeLists.txt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants