fix: pass null instead of undefined to requestCompleted on success - #6837
Merged
Conversation
climba03003
requested changes
Jul 8, 2026
climba03003
left a comment
climba03003
left a comment
Member
There was a problem hiding this comment.
I would rather update the types instead of code.
Doing nullish assignment here for the undefined seems useless operation.
Contributor
Author
|
Pushed. Reverted the runtime change and widened |
This comment was marked as abuse.
This comment was marked as abuse.
climba03003
previously approved these changes
Jul 15, 2026
Member
|
@lazerg As soon as you have time, can you resolve conflicts? |
lazerg
force-pushed
the
fix/issue-6836-request-completed-null
branch
from
August 4, 2026 09:18
0c3ff6d to
2454bf8
Compare
climba03003
approved these changes
Aug 4, 2026
gurgunday
approved these changes
Aug 6, 2026
Eomm
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node's
finishevent onhttp.ServerResponsefires with no arguments, soonResFinishedinlib/reply.jswas passingundefinedtorequestCompletedfor successful responses instead ofnull. That didn't match theError | nulltype intypes/logger.d.ts(and the matching JSDoc inlib/log-controller.js), so code branching onerror === nullnever matched the success case. Normalized tonullat the call site and added a regression test.Fixes #6836