Skip to content

fix: pass null instead of undefined to requestCompleted on success #6837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eomm merged 2 commits into from
Aug 6, 2026
+2 −2
Merged

fix: pass null instead of undefined to requestCompleted on success #6837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5735df
fix: pass null instead of undefined to requestCompleted on success
lazerg Jul 7, 2026
2454bf8
fix: widen requestCompleted error type to include undefined
lazerg Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/log-controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class LogController {
* Logs the outcome of a completed request.
* Uses `error` level when an error is present, `info` otherwise.
*
* @param {Error | null} error Error that occurred during the response, if any.
* @param {Error | null | undefined} error Error that occurred during the response, if any.
* @param {object} request Fastify request object.
* @param {object} reply Fastify reply object.
* @param {object} [metadata] Extra contextual data (unused).
Expand Down
2 changes: 1 addition & 1 deletion types/logger.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ export declare class LogController {
isLogDisabled (request: FastifyRequest): boolean
incomingRequest (request: FastifyRequest, reply: FastifyReply, metadata?: Record<string, unknown>): void
requestCompleted (
error: Error | null,
error: Error | null | undefined,
request: FastifyRequest,
reply: FastifyReply,
metadata?: Record<string, unknown>
Expand Down
Loading