refactor code according to pandas 1.5.0 and sklearn 1.2.0 releases - #625
Conversation
|
Hey @luismavs Awsome job, thank you! We need a small fix here for style tests: |
|
I just noticed 2 extra files that I think helped you find the warnings. If you remove those, you can probably also rebase main and then the test would pass. Let me know whenever you think this is ready to merge. I've seen some discussions on linkedin about this issue from pandas. Thank you so much for picking it up! :) |
Codecov Report
@@ Coverage Diff @@
## main #625 +/- ##
=======================================
Coverage 97.90% 97.90%
=======================================
Files 98 98
Lines 3588 3588
Branches 695 695
=======================================
Hits 3513 3513
Misses 28 28
Partials 47 47
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hi, files removed and code rebased from main, it should be ok now. |
|
Hey @luismavs Not sure what went wrong, but something broke with the last commits. Could you have a look? I'll really appreciate it :) |
|
closing and reopening to see if tests pass |
|
Hey @luismavs ignore my comment, it was some failure to load a dataframe from an url, for another unrelated test. Merging as we speak. Thanks a lot for the contribution! |
Update to fix some Warnings when running code with recent Pandas (>=1.5.0) and Scikit-Learn (>=1.2.0).
Specifically, the following types of warnings were fixed: