Skip to content

[MRG] switch include_lowest to True in discretizers - #627

Merged
solegalli merged 8 commits into
mainfrom
disc_include_lowest
Mar 7, 2023
Merged

[MRG] switch include_lowest to True in discretizers#627
solegalli merged 8 commits into
mainfrom
disc_include_lowest

Conversation

@solegalli

@solegalli solegalli commented Mar 7, 2023

Copy link
Copy Markdown
Collaborator

closes #626
closes #628

See for doc fix:
sphinx-doc/sphinx#11062

In case we need to revert

@solegalli solegalli changed the title switch include_lowest to True in discretizers [MRG] switch include_lowest to True in discretizers Mar 7, 2023
@codecov

codecov Bot commented Mar 7, 2023

Copy link
Copy Markdown

Codecov Report

Merging #627 (256514e) into main (71efa79) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #627   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files          96       96           
  Lines        3554     3554           
  Branches      685      685           
=======================================
  Hits         3479     3479           
  Misses         28       28           
  Partials       47       47           
Impacted Files Coverage Δ
feature_engine/discretisation/base_discretiser.py 100.00% <ø> (ø)
feature_engine/discretisation/equal_width.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@solegalli
solegalli merged commit 7850eca into main Mar 7, 2023
@solegalli
solegalli deleted the disc_include_lowest branch March 7, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs issue with favicons discretizers should be left inclusive

1 participant