chore: correct Zed configuration for Deno LSP - #405
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @moreal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refines the configuration for Deno's Language Server Protocol (LSP) within the Zed editor. While the previous setup was functional, this change adopts the officially recommended and more robust configuration structure, ensuring future compatibility and explicit control over LSP features.
Highlights
- Zed Configuration Correction: The
.zed/settings.jsonfile has been updated to align with the correct nested structure for Deno LSP configuration, movingdeno.enableanddeno.unstableintolsp.deno.settings.deno. This ensures proper control over Deno LSP behavior within the Zed editor.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly updates the Zed editor's settings for the Deno LSP. By moving the Deno configuration under the lsp key, it aligns with the documented and correct structure. This is a good maintenance change that improves the project's development environment configuration. The change is straightforward and looks good.
|
The latest push to this pull request has been published to JSR and npm as a pre-release:
|
|
The docs for this pull request have been published: |
Summary
This pull request just modifies only
.zed/settings.jsonto correct Zed configuration for Deno LSP.Related Issue
There is no related issue.
Changes
Changes of this pull request is very simple:
Benefits
While it worked previously, there's no real benefit to this change, but we'll use the proper configuration. Setting
deno.enableto false still enables Deno LSP, but changing theenablesetting in the modified configuration to false appears to disable it.Checklist
deno task test-allon your machine?Additional Notes
Refer: