Migrate /contact-sales to design tokens + extract shared form primitives - #93
Merged
filipagr merged 1 commit intoJul 29, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Anchor page for the form/contact bucket (FIL-693). Tokenizes ContactSales (zero inline styles, hex, or raw font strings) and extracts the reusable form building blocks the other six form pages will consume: - FormControls.tsx: FIELD_INPUT_CLASS, FormField, TextField, RadioField, Checkbox, SubmitButton, FormSuccess. Tokenized visuals + baked-in a11y (role=status/alert, keyboard focus rings). Composable primitives, not a monolithic form template (waitlist pages use a different shape). - hubspot.ts: submitHubSpotForm() centralizes the Forms-API fetch + error parsing; pages just build their fields array. - ContactSales.tsx: rebuilt on the primitives + SectionLabel; keeps the HubSpot submit and data-hs-do-not-collect intact. Also: text inputs now show the site-wide brand focus-visible ring (was suppressed) and RadioField spaces its legend from the options via a legend margin, since a <legend> in a flex fieldset is not a flex item so `gap` never applied. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
filipagr
force-pushed
the
filipa/fil-846-migrate-contact-sales-to-design-tokens-shared-components
branch
from
July 29, 2026 13:56
a6fb48a to
18aadf1
Compare
This was referenced Jul 29, 2026
gmoranxyz
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anchor page for the form/contact bucket (FIL-846 / FIL-693). Migrates
/contact-salesonto design tokens and extracts the reusable form building blocks that the remaining six form pages (FIL-847…FIL-852) will consume.What changed
src/components/FormControls.tsx— shared, composable form primitives:FIELD_INPUT_CLASS,FormField,TextField,RadioField,Checkbox,SubmitButton,FormSuccess. Tokenized visuals with baked-in a11y (role="status"/role="alert", keyboard focus rings). Deliberately primitives, not a monolithic form template — the waitlist pages use a per-field/checkbox-group shape that wouldn't fit one.src/lib/hubspot.ts— newsubmitHubSpotForm()helper centralizes the Forms-API fetch + error parsing; pages just build theirfieldsarray.src/pages/ContactSales.tsx— rebuilt on the primitives +SectionLabel. Zero inlinestyle={{}}, zero hardcoded hex, zero raw font strings (was 26 / 28 / 3). HubSpot submit anddata-hs-do-not-collectpreserved.Notable
focus-visiblering (previously suppressed by an inlineoutline:none) — a WCAG 2.4.7 improvement.RadioFieldspaces its legend from the options via a margin on the<legend>: a<legend>in adisplay:flexfieldset is not a flex item, so the fieldsetgapnever applied to the heading→options spacing (it was 0px). Commented in-code.Verification
🤖 Generated with Claude Code