Migrate /partners/apply to design tokens + shared form primitives - #95
Merged
filipagr merged 1 commit intoJul 30, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Jul 29, 2026
filipagr
force-pushed
the
filipa/fil-848-migrate-partners-apply-to-design-tokens-shared-components
branch
from
July 30, 2026 18:32
ee2bcf9 to
bf86ba2
Compare
Base automatically changed from
filipa/fil-847-migrate-support-to-design-tokens-shared-components
to
main
July 30, 2026 18:34
Third page in the form/contact bucket (FIL-693); stacked on FIL-847. Tokenizes PartnerApplyPage (63 → 0 inline/hex/font-string) and moves every form control onto shared primitives — the page now has zero raw form elements. - PartnerApplyPage.tsx: rebuilt on TextField/TextAreaField/SelectField/ RadioCardField/Checkbox/SubmitButton/FormSuccess/FormError + SectionLabel. HubSpot submit + data-hs-do-not-collect intact. - FormControls.tsx: new primitives extracted from this page — * SelectField (native select + shared chevron) * RadioCardField (card-style single-select with descriptions) * FormError (boxed role="alert" error) extend FormSuccess with optional `align` + `action` (backward-compatible; contact-sales/support unaffected) so the centered "Back to Partners" success reuses it. Fix a className-merge bug so TextField/TextAreaField/SelectField append a caller's className instead of clobbering the base styles. Fix a live display bug: the Company-size dropdown rendered "1-10 employees employees" (the option template appended a suffix the values already had). Submitted value is unchanged; only the visible label is fixed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
filipagr
force-pushed
the
filipa/fil-848-migrate-partners-apply-to-design-tokens-shared-components
branch
from
July 30, 2026 18:34
bf86ba2 to
4c35176
Compare
filecoinfoundation-inf
approved these changes
Jul 30, 2026
filecoinfoundation-inf
left a comment
filecoinfoundation-inf
left a comment
There was a problem hiding this comment.
Same shared-form-primitives refactor pattern; also extends FormControls with SelectField, RadioCardField, and a reusable FormError/FormSuccess (with align/action options). No security concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third page in the form/contact bucket (FIL-848 / FIL-693). Migrates
/partners/apply(~63 → 0 inline/hex/font-string). The page now has zero raw form elements — every control runs through a shared primitive.What changed
src/pages/PartnerApplyPage.tsx— rebuilt onTextField/TextAreaField/SelectField/RadioCardField/Checkbox/SubmitButton/FormSuccess/FormError+SectionLabel. HubSpot submit +data-hs-do-not-collectintact.src/components/FormControls.tsx— new primitives extracted from this page:SelectField— native select with the shared chevron.RadioCardField— card-style single-select with per-option descriptions + brand-tinted selection.FormError— boxedrole="alert"error.FormSuccessextended with optionalalign+action(backward-compatible — contact-sales/support unaffected), so the centered "Back to Partners" success reuses it.TextField/TextAreaField/SelectFieldnow append a caller'sclassNameinstead of overwriting the base styles.Bug fix (live)
The Company-size dropdown rendered "1-10 employees employees" — the
<option>appended a suffix the array values already had. Removed the duplicate. Submitted value unchanged (company_sizestill posts "1-10 employees"); only the visible label is fixed.Verification
🤖 Generated with Claude Code