Use shared FormError on contact-sales + support - #96
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Jul 29, 2026
filipagr
force-pushed
the
filipa/form-error-consistency
branch
from
July 30, 2026 18:32
4b82e46 to
58ece3c
Compare
filipagr
force-pushed
the
filipa/form-error-consistency
branch
from
July 30, 2026 18:34
58ece3c to
d2011df
Compare
filecoinfoundation-inf
approved these changes
Jul 30, 2026
filecoinfoundation-inf
left a comment
filecoinfoundation-inf
left a comment
There was a problem hiding this comment.
Trivial cleanup swapping inline error markup for the shared FormError component on ContactSales/Support. No concerns.
Base automatically changed from
filipa/fil-848-migrate-partners-apply-to-design-tokens-shared-components
to
main
July 30, 2026 21:42
Consistency follow-up: contact-sales and support showed submit errors as plain centered red text, while partner-apply uses the boxed FormError callout. Swap both onto the shared <FormError> so every form in the bucket announces errors identically (role="alert", boxed danger treatment). Depends on FormError (introduced in the partners-apply migration), so this is stacked on that branch. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
filipagr
force-pushed
the
filipa/form-error-consistency
branch
from
July 30, 2026 21:43
d2011df to
e865f02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consistency follow-up for the form/contact bucket (FIL-693). contact-sales and support showed submit errors as plain centered red text, while partner-apply uses the boxed
FormErrorcallout. This swaps both onto the shared<FormError>so every form announces errors identically (role="alert", boxed danger treatment).Changed
src/pages/ContactSales.tsx,src/pages/Support.tsx— replace the inline plain-text error<p>with<FormError>{error}</FormError>and import it.Verification
FormErrorrenders below the submit button (matching partner-apply), then reverted the seed.🤖 Generated with Claude Code