dataconnect(build): fix CopySharedWithAndroidTestFiles.kt to delete the output directory before writing to it#8132
Conversation
…ar previously-generated files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
There was a problem hiding this comment.
Code Review
This pull request modifies the CopySharedWithAndroidTestFiles Gradle task to ensure the output directory is deleted before file copying begins, utilizing FileSystemOperations. It also introduces a custom OutputDirectoryDeleteFailedException for error handling. The review feedback recommends making this exception class private to improve encapsulation.
This PR updates the
CopySharedWithAndroidTestFilesGradle task to ensure the output directory is deleted before copying files, preventing stale or conflicting files from persisting across task executions.Highlights
FileSystemOperationstoCopySharedWithAndroidTestFilesvia Gradle's@Inject.outputDirectoryif it already exists at the start of the task action.OutputDirectoryDeleteFailedExceptionto handle cases where the output directory cannot be successfully deleted.Changelog
1 file affected
CopySharedWithAndroidTestFiles.kt: Modified therun()function to delete the output directory before copying files; addedFileSystemOperationsinjection andOutputDirectoryDeleteFailedExceptionclass.