Skip to content

dataconnect(build): fix CopySharedWithAndroidTestFiles.kt to delete the output directory before writing to it#8132

Merged
dconeybe merged 1 commit into
mainfrom
dconeybe/dataconnect/CopySharedWithAndroidTestFilesDeleteFix
May 11, 2026
Merged

dataconnect(build): fix CopySharedWithAndroidTestFiles.kt to delete the output directory before writing to it#8132
dconeybe merged 1 commit into
mainfrom
dconeybe/dataconnect/CopySharedWithAndroidTestFilesDeleteFix

Conversation

@dconeybe

@dconeybe dconeybe commented May 10, 2026

Copy link
Copy Markdown
Contributor

This PR updates the CopySharedWithAndroidTestFiles Gradle task to ensure the output directory is deleted before copying files, preventing stale or conflicting files from persisting across task executions.

Highlights

  • Added FileSystemOperations to CopySharedWithAndroidTestFiles via Gradle's @Inject.
  • Implemented a check to delete the outputDirectory if it already exists at the start of the task action.
  • Introduced OutputDirectoryDeleteFailedException to handle cases where the output directory cannot be successfully deleted.

Changelog

1 file affected
  • CopySharedWithAndroidTestFiles.kt: Modified the run() function to delete the output directory before copying files; added FileSystemOperations injection and OutputDirectoryDeleteFailedException class.

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@dconeybe

Copy link
Copy Markdown
Contributor Author

/gemini review

@github-actions

Copy link
Copy Markdown
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the CopySharedWithAndroidTestFiles Gradle task to ensure the output directory is deleted before file copying begins, utilizing FileSystemOperations. It also introduces a custom OutputDirectoryDeleteFailedException for error handling. The review feedback recommends making this exception class private to improve encapsulation.

@dconeybe dconeybe marked this pull request as ready for review May 10, 2026 21:53
@dconeybe dconeybe merged commit e2f733d into main May 11, 2026
43 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/CopySharedWithAndroidTestFilesDeleteFix branch May 11, 2026 18:16
@firebase firebase locked and limited conversation to collaborators Jun 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants