Skip to content

dataconnect(chore): internal cleanup of logging from GrpcBidiFlow#8340

Merged
dconeybe merged 3 commits into
mainfrom
dconeybe/dataconnect/GrpcBidiFlowLowCleanup
Jun 22, 2026
Merged

dataconnect(chore): internal cleanup of logging from GrpcBidiFlow#8340
dconeybe merged 3 commits into
mainfrom
dconeybe/dataconnect/GrpcBidiFlowLowCleanup

Conversation

@dconeybe

@dconeybe dconeybe commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

This PR performs an internal cleanup of the logging and lifecycle callbacks in data connect's GrpcBidiFlow and improves resilience during stream shutdown in the firebase-dataconnect module.

Highlights

  • Improved gRPC Logging & Lifecycle Callbacks:
    • Added support for capturing and logging gRPC call headers via new onCallHeaders and onHeaders callbacks.
    • Removed the redundant receivedMessage callback, relying instead on onCallMessage which is invoked directly when a message is received from the gRPC stream.
  • Resilient Shutdown Handling: Modified GrpcBidiFlow to ignore message sending failures in onMessage when the underlying responses channel is already closed, preventing potential crashes during stream teardown.
Changelog
  • DataConnectGrpcRPCs.kt
    • Implemented onCallHeaders and onHeaders to log metadata headers.
    • Removed the obsolete receivedMessage callback.
  • GrpcBidiFlow.kt
    • Added onCallHeaders callback to GrpcBidiFlow.Listener and propagated gRPC headers received in ClientCall.Listener.onHeaders to the listener.
    • Removed the redundant receivedMessage callback from the collection loop, listeners, and message formatter.
    • Added a safety check in onMessage to ignore failures from responses.trySend if the channel is already closed.

@dconeybe

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors GrpcBidiFlow and its listeners by replacing the receivedMessage callback with onCallHeaders to capture and propagate gRPC metadata headers. It also introduces a safety check in onMessage to ignore trySend failures if the response channel is already closed. The reviewer pointed out an unused import alias GrpcChannel in DataConnectGrpcRPCs.kt that should be removed.

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@github-actions

Copy link
Copy Markdown
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@dconeybe dconeybe marked this pull request as ready for review June 22, 2026 19:51

@stephenarosaj stephenarosaj left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dconeybe dconeybe merged commit 5c74949 into main Jun 22, 2026
50 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/GrpcBidiFlowLowCleanup branch June 22, 2026 19:52
@github-actions github-actions Bot mentioned this pull request Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants