dataconnect(chore): internal cleanup of logging from GrpcBidiFlow#8340
Conversation
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors GrpcBidiFlow and its listeners by replacing the receivedMessage callback with onCallHeaders to capture and propagate gRPC metadata headers. It also introduces a safety check in onMessage to ignore trySend failures if the response channel is already closed. The reviewer pointed out an unused import alias GrpcChannel in DataConnectGrpcRPCs.kt that should be removed.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
This PR performs an internal cleanup of the logging and lifecycle callbacks in data connect's
GrpcBidiFlowand improves resilience during stream shutdown in thefirebase-dataconnectmodule.Highlights
onCallHeadersandonHeaderscallbacks.receivedMessagecallback, relying instead ononCallMessagewhich is invoked directly when a message is received from the gRPC stream.GrpcBidiFlowto ignore message sending failures inonMessagewhen the underlyingresponseschannel is already closed, preventing potential crashes during stream teardown.Changelog
onCallHeadersandonHeadersto log metadata headers.receivedMessagecallback.onCallHeaderscallback toGrpcBidiFlow.Listenerand propagated gRPC headers received inClientCall.Listener.onHeadersto the listener.receivedMessagecallback from the collection loop, listeners, and message formatter.onMessageto ignore failures fromresponses.trySendif the channel is already closed.