Skip to content

dataconnect(test): AuthIntegrationTest.kt: added realtime query subscription tests#8341

Merged
dconeybe merged 2 commits into
mainfrom
dconeybe/dataconnect/AuthIntegrationTestRealtimeTests
Jun 22, 2026
Merged

dataconnect(test): AuthIntegrationTest.kt: added realtime query subscription tests#8341
dconeybe merged 2 commits into
mainfrom
dconeybe/dataconnect/AuthIntegrationTestRealtimeTests

Conversation

@dconeybe

@dconeybe dconeybe commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

This PR introduces integration tests for data connect's real-time query subscriptions for validating behavior across different authentication states. To support these tests, new authenticated query and mutation operations are added to the real-time test schema, and client wrapper properties are exposed in the generated RealtimeConnector class.

Highlights

  • Real-time Subscription Integration Tests: Added four comprehensive integration tests in AuthIntegrationTest.kt to verify that real-time query subscriptions correctly enforce authorization rules, successfully receive streaming updates when authenticated, and raise a FirebaseUserChangedException when user sign-in or sign-out events occur during an active subscription.
  • Schema and Generated Client Additions: Updated realtime_ops.gql to define RealtimeString_Insert_Auth and RealtimeString_GetByKey_Auth with anonymous user authorization level. Exposed corresponding insertStringAuth and getStringByKeyAuth methods in the generated RealtimeConnector class, along with new queryRef convenience overloads.
  • Authentication Test Helper Improvements: Refactored the signIn and signOut helper methods in AuthIntegrationTest.kt to dynamically extract the FirebaseAuth instance from instrumentation arguments rather than relying on a hardcoded instance, and introduced overloaded helpers accepting PersonSchema to simplify test code.
Changelog
  • realtime_ops.gql
    • Added RealtimeString_Insert_Auth mutation and RealtimeString_GetByKey_Auth query, both restricted to the USER_ANON authorization level.
  • RealtimeConnector.kt
    • Exposed insertStringAuth (InsertStringMutationAuth) and getStringByKeyAuth (GetStringByKeyQueryAuth) properties to support authenticated client calls.
    • Added queryRef helper overloads taking String and UUID to streamline querying by ID.
  • AuthIntegrationTest.kt
    • Added realtimeQuerySubscriptionUnauthenticated, realtimeQuerySubscriptionAuthenticated, realtimeQuerySubscriptionErrorsOnSignIn, and realtimeQuerySubscriptionErrorsOnSignOut test cases.
    • Refactored signIn and signOut helpers to dynamically retrieve the FirebaseAuth instance for the given Firebase App using instrumentation arguments.
    • Added signIn and signOut helper overloads taking a PersonSchema parameter.

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@dconeybe

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces authenticated operations for realtime queries and mutations, along with comprehensive integration tests verifying subscription behavior under different authentication states (unauthenticated, authenticated, and user changes). The reviewer feedback suggests adding convenience overloads to the newly introduced GetStringByKeyQueryAuth and InsertStringMutationAuth classes to maintain consistency with existing query and mutation helpers.

@github-actions

Copy link
Copy Markdown
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@dconeybe dconeybe marked this pull request as ready for review June 22, 2026 20:24

@stephenarosaj stephenarosaj left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dconeybe dconeybe merged commit 27d7c12 into main Jun 22, 2026
49 of 50 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/AuthIntegrationTestRealtimeTests branch June 22, 2026 21:09
@github-actions github-actions Bot mentioned this pull request Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants