This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Fix double scrollbar issue in SourcesTree #5787
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jasonLaster discovered a double scrollbar in the Sources Tree. I couldn't spot it on Mac but Windows made the problem more visible.
After testing things out, I found what I consider to be the issue: I'm applying CSS code to the
sources-listat all states when it only needs to be applied when the custom root is showing.The sources tree layout stuff got complicated when we switched to the directory root button/layout because we always wanted that clear button on top, and so we had to go with absolute positioning and so on, thus the scrollbar situation got complicated.
Testing
pagead2.googlesyndication.comas the root directoryThis is easier to test on windows since the scrollbars are always there and don't overlay the content.