Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

[Workers] polish the ui#7622

Merged
jasonLaster merged 1 commit intofirefox-devtools:masterfrom
jasonLaster:workers-polish
Jan 3, 2019
Merged

[Workers] polish the ui#7622
jasonLaster merged 1 commit intofirefox-devtools:masterfrom
jasonLaster:workers-polish

Conversation

@jasonLaster
Copy link
Copy Markdown
Contributor

@jasonLaster jasonLaster commented Dec 31, 2018

Summary of Changes

  • cleans up source tree
  • cleans up workers pane

screen shot 2018-12-31 at 11 46 15 am

@jasonLaster jasonLaster requested a review from flodolo as a code owner January 1, 2019 22:30
@jasonLaster jasonLaster force-pushed the workers-polish branch 3 times, most recently from 5372e12 to 091b5ff Compare January 1, 2019 23:32
bhackett1024
bhackett1024 reviewed Jan 1, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@bhackett1024 bhackett1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, in the future do you think we'll need a way to distinguish tabs/breakpoints from different threads that have the same URL, or is this just an obscure enough use case that it doesn't need handling in the UI?

Comment thread assets/panel/debugger.properties Outdated
# header.
workersHeader=Workers

# LOCALIZATION NOTE (mainThread): The text to describe the main thred of the
Copy link
Copy Markdown
Contributor

@bhackett1024 bhackett1024 Jan 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@jasonLaster
Copy link
Copy Markdown
Contributor Author

jasonLaster commented Jan 2, 2019

do you think we'll need a way to distinguish tabs/breakpoints from different threads that have the same URL?

My guess is yes, but waiting for some design help there

jasonLaster
jasonLaster commented Jan 2, 2019
View reviewed changes
Comment thread src/reducers/sources.js Outdated
thread: string
): SourcesMap {
return getRelativeSources(state)[thread];
return getRelativeSources(state)[thread] || {};
Copy link
Copy Markdown
Contributor Author

@jasonLaster jasonLaster Jan 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i feel like this should not be necessary

the strange thing is that i needed this because in SourcesTree, state.sources.relativeSources was empty, but... dbg.store.getState().sources.relativeSources was not. I am really confused by this

screen shot 2019-01-02 at 9 06 45 am

@jasonLaster jasonLaster force-pushed the workers-polish branch 8 times, most recently from 7c9f3a1 to 896164e Compare January 2, 2019 23:12
@jasonLaster jasonLaster changed the title (WIP) [Workers] polish the ui [Workers] polish the ui Jan 2, 2019
@jasonLaster jasonLaster force-pushed the workers-polish branch 2 times, most recently from e9760a6 to 8fd54c3 Compare January 2, 2019 23:58
@jasonLaster jasonLaster force-pushed the workers-polish branch 5 times, most recently from afbdb13 to 2eeabf6 Compare January 3, 2019 17:59
darkwing
darkwing reviewed Jan 3, 2019
View reviewed changes
Comment thread src/components/SecondaryPanes/Workers.js Outdated
>
<AccessibleImage className="domain" />
{basename(worker.url)}
<div clasName="icon">
Copy link
Copy Markdown
Contributor

@darkwing darkwing Jan 3, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo (className)

@darkwing
Copy link
Copy Markdown
Contributor

darkwing commented Jan 3, 2019

It's amazing to see this working! Wow!

Could we have the headings be part of the tree widget itself, so that entire threads could be opened and closed? That could reduce visual clutter when there are many threads.

@jasonLaster jasonLaster force-pushed the workers-polish branch 2 times, most recently from 3e2acce to 9b0af9f Compare January 3, 2019 19:05
@jasonLaster jasonLaster merged commit fc91fea into firefox-devtools:master Jan 3, 2019
jasonLaster added a commit to jasonLaster/debugger.html that referenced this pull request Jan 7, 2019
@jasonLaster
[workers] polish the ui (firefox-devtools#7622)
83a64ff
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@flodolo flodolo Awaiting requested review from flodolo

2 more reviewers

@darkwing darkwing darkwing left review comments

@bhackett1024 bhackett1024 bhackett1024 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jasonLaster @darkwing @bhackett1024