-
Notifications
You must be signed in to change notification settings - Fork 450
Scale custom marker graphs on values within the committed range. #5587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scale custom marker graphs on values within the committed range. #5587
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5587 +/- ##
=======================================
Coverage 85.78% 85.78%
=======================================
Files 309 309
Lines 30403 30416 +13
Branches 8370 8371 +1
=======================================
+ Hits 26080 26092 +12
- Misses 3902 3903 +1
Partials 421 421 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mstange
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed in detail yet but it seems there's some code duplication. Is there a way to share more of this code? Or would that come with disadvantages?
eb84bd8 to
284dccc
Compare
I cleaned up the minNumber/maxNumber computation to have it done in a separate selector. There was no real need to compute the min/max for the entire range anyway. |
284dccc to
c9d3de5
Compare
Changes: [Markus Stange] Switch CSS back to using relative paths inside url(...) (#5594) [Markus Stange] Use dynamic imports for jszip (#5593) [Florian Quèze] Allow markers to provide a marker color. (#5607) [Ryan Hunt] Update iongraph-web to latest version (#5606) [Florian Quèze] Fix the color contrast of hovered colored markers. (#5609) [Florian Quèze] Scale custom marker graphs on values within the committed range. (#5587) [Markus Stange] Fix null marker stack substitution (#5613) [Florian Quèze] Track context menus should be accessible from anywhere in the track (#5562) [Markus Stange] Worker + compression cleanups (#5602)
Example profile: https://share.firefox.dev/4pbjdi8
Deploy preview