Skip to content

Conversation

@fqueze
Copy link
Contributor

@fqueze fqueze commented Sep 3, 2025

@fqueze fqueze requested a review from mstange September 3, 2025 21:28
@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.78%. Comparing base (d956b46) to head (c9d3de5).
⚠️ Report is 54 commits behind head on main.

Files with missing lines Patch % Lines
src/selectors/per-thread/markers.ts 94.44% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5587   +/-   ##
=======================================
  Coverage   85.78%   85.78%           
=======================================
  Files         309      309           
  Lines       30403    30416   +13     
  Branches     8370     8371    +1     
=======================================
+ Hits        26080    26092   +12     
- Misses       3902     3903    +1     
  Partials      421      421           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mstange mstange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed in detail yet but it seems there's some code duplication. Is there a way to share more of this code? Or would that come with disadvantages?

@fqueze fqueze force-pushed the scale-custommarkergraph-on-committed-range branch from eb84bd8 to 284dccc Compare September 9, 2025 11:23
@fqueze
Copy link
Contributor Author

fqueze commented Sep 9, 2025

I haven't reviewed in detail yet but it seems there's some code duplication. Is there a way to share more of this code? Or would that come with disadvantages?

I cleaned up the minNumber/maxNumber computation to have it done in a separate selector. There was no real need to compute the min/max for the entire range anyway.

@fqueze fqueze requested a review from mstange September 9, 2025 11:25
@fqueze fqueze force-pushed the scale-custommarkergraph-on-committed-range branch from 284dccc to c9d3de5 Compare September 10, 2025 19:31
@fqueze fqueze enabled auto-merge (squash) September 10, 2025 19:34
@fqueze fqueze merged commit d3dfa05 into firefox-devtools:main Sep 10, 2025
12 of 13 checks passed
@fqueze fqueze deleted the scale-custommarkergraph-on-committed-range branch September 10, 2025 19:42
canova added a commit that referenced this pull request Sep 16, 2025
Changes:

[Markus Stange] Switch CSS back to using relative paths inside url(...)
(#5594)
[Markus Stange] Use dynamic imports for jszip (#5593)
[Florian Quèze] Allow markers to provide a marker color. (#5607)
[Ryan Hunt] Update iongraph-web to latest version (#5606)
[Florian Quèze] Fix the color contrast of hovered colored markers.
(#5609)
[Florian Quèze] Scale custom marker graphs on values within the
committed range. (#5587)
[Markus Stange] Fix null marker stack substitution (#5613)
[Florian Quèze] Track context menus should be accessible from anywhere
in the track (#5562)
[Markus Stange] Worker + compression cleanups (#5602)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants