Switch CSS back to using relative paths inside url(...) #5594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esbuild doesn't respect aliases for url() references in CSS files. We could add a plugin which implements this mapping but it seems fine to just change this to use relative URLs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5594 +/- ##
=======================================
Coverage 85.80% 85.80%
=======================================
Files 309 309
Lines 30381 30381
Branches 8365 8365
=======================================
Hits 26068 26068
Misses 3892 3892
Partials 421 421 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
canova
approved these changes
Sep 8, 2025
canova
added a commit
that referenced
this pull request
Sep 16, 2025
Changes: [Markus Stange] Switch CSS back to using relative paths inside url(...) (#5594) [Markus Stange] Use dynamic imports for jszip (#5593) [Florian Quèze] Allow markers to provide a marker color. (#5607) [Ryan Hunt] Update iongraph-web to latest version (#5606) [Florian Quèze] Fix the color contrast of hovered colored markers. (#5609) [Florian Quèze] Scale custom marker graphs on values within the committed range. (#5587) [Markus Stange] Fix null marker stack substitution (#5613) [Florian Quèze] Track context menus should be accessible from anywhere in the track (#5562) [Markus Stange] Worker + compression cleanups (#5602)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically picking the opposite direction of #5581.
With esbuild you can configure aliases, but it only respects them for imports into JS. It doesn't respect the aliases for url() references in CSS files. We could add a plugin which implements this mapping but it seems easier (and maybe more idiomatic) to just change our CSS to use relative URLs.