Skip to content

Conversation

@mstange
Copy link
Contributor

@mstange mstange commented Sep 5, 2025

Production | Main branch | Deploy preview

See individual commits.

@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 10.00000% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.72%. Comparing base (f6db0d3) to head (52b1d06).

Files with missing lines Patch % Lines
src/utils/gz.ts 12.50% 14 Missing ⚠️
src/utils/gz.worker.js 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5602      +/-   ##
==========================================
- Coverage   85.81%   85.72%   -0.10%     
==========================================
  Files         309      310       +1     
  Lines       30371    30407      +36     
  Branches     8362     8371       +9     
==========================================
+ Hits        26063    26065       +2     
- Misses       3887     3919      +32     
- Partials      421      423       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…rker.js.

This allows us to keep the worker file located close to the file
which uses it. It also makes it easier to have equivalent handling
in esbuild.
I r+ed their removal in firefox-devtools#5584 because node supports CompressionStream,
but I forgot to ask for the fallbacks to be put back when we switched
back to using a worker.
}

return result;
return new Uint8Array(await new Response(stream).arrayBuffer());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification!

@canova
Copy link
Member

canova commented Sep 15, 2025

(I didn't try the code manually in a node environment like symbolicator-cli, but I assume you tried it already)

@canova canova enabled auto-merge September 15, 2025 10:17
@canova canova merged commit 4cb392a into firefox-devtools:main Sep 15, 2025
12 of 13 checks passed
canova added a commit that referenced this pull request Sep 16, 2025
Changes:

[Markus Stange] Switch CSS back to using relative paths inside url(...)
(#5594)
[Markus Stange] Use dynamic imports for jszip (#5593)
[Florian Quèze] Allow markers to provide a marker color. (#5607)
[Ryan Hunt] Update iongraph-web to latest version (#5606)
[Florian Quèze] Fix the color contrast of hovered colored markers.
(#5609)
[Florian Quèze] Scale custom marker graphs on values within the
committed range. (#5587)
[Markus Stange] Fix null marker stack substitution (#5613)
[Florian Quèze] Track context menus should be accessible from anywhere
in the track (#5562)
[Markus Stange] Worker + compression cleanups (#5602)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants