-
Notifications
You must be signed in to change notification settings - Fork 450
Worker + compression cleanups #5602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5602 +/- ##
==========================================
- Coverage 85.81% 85.72% -0.10%
==========================================
Files 309 310 +1
Lines 30371 30407 +36
Branches 8362 8371 +9
==========================================
+ Hits 26063 26065 +2
- Misses 3887 3919 +32
- Partials 421 423 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…rker.js. This allows us to keep the worker file located close to the file which uses it. It also makes it easier to have equivalent handling in esbuild.
I r+ed their removal in firefox-devtools#5584 because node supports CompressionStream, but I forgot to ask for the fallbacks to be put back when we switched back to using a worker.
| } | ||
|
|
||
| return result; | ||
| return new Uint8Array(await new Response(stream).arrayBuffer()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice simplification!
|
(I didn't try the code manually in a node environment like symbolicator-cli, but I assume you tried it already) |
Changes: [Markus Stange] Switch CSS back to using relative paths inside url(...) (#5594) [Markus Stange] Use dynamic imports for jszip (#5593) [Florian Quèze] Allow markers to provide a marker color. (#5607) [Ryan Hunt] Update iongraph-web to latest version (#5606) [Florian Quèze] Fix the color contrast of hovered colored markers. (#5609) [Florian Quèze] Scale custom marker graphs on values within the committed range. (#5587) [Markus Stange] Fix null marker stack substitution (#5613) [Florian Quèze] Track context menus should be accessible from anywhere in the track (#5562) [Markus Stange] Worker + compression cleanups (#5602)
Production | Main branch | Deploy preview
See individual commits.