CData: address write_value issue in _parameters.csv - #2336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the CData behavior reported in Discussion #2331 where
Simple_parameters.csvwas created with the expected headers and case names, but the randomized parameter values were blank.Root cause: the CData parameter-output path had been disconnected in commit
7264729eb(CData: fixed error in write and removed unused code). In that change, the calls towrite_valueincreate_casewere commented out. Because those calls were no longer active, thewrite_valueroutine later appeared unused and was removed. The result was that CData still created the parameter CSV header row withadd_header, but never copied each generated case’s sampled values into the row beforeflush_parameters_buffer.The fix restores that missing path:
write_valueroutine forvalue_wrapper_type.write_valuecalls after each random fire and field is randomized increate_case.FIRE_DO_RANDbehavior that avoids randomizing unassociated fire-generator points, so the previous CData crash fix remains intact.read_input_file(.false.), so preprocessing does not create empty base-case CFAST output files such asSimple_vents.csvwhile runningcdata Simple.in -P.After this change, running: