Skip to content

fix: fix empty map tile collisions loading as solid tiles. #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zicklag merged 1 commit into from
Mar 9, 2023
Merged

fix: fix empty map tile collisions loading as solid tiles. #689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion core/src/map.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,16 @@ fn spawn_map(
..default()
},
);
tile_collisions.insert(tile_ent, tile_meta.collision);
// TODO: Due to a bug in the way that collisions are handled in the
// `physics/collisions.rs` file, having an empty collision isn't equivalent to not
// having a collision component.
//
// We should fix this so that we can insert an empty tile collision kind and have that
// work properly. For now, though, just not adding the tile collider component behaves
// properly.
if tile_meta.collision != TileCollisionKind::Empty {
tile_collisions.insert(tile_ent, tile_meta.collision);
}
}
let layer_ent = entities.create();
spawned_map_layer_metas.insert(layer_ent, SpawnedMapLayerMeta { layer_idx });
Expand Down