UI – adjust disk encryption table style#20981
Merged
jacobshandling merged 3 commits intomainfrom Aug 2, 2024
Merged
Conversation
jacobshandling
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Contributor
ghernandez345
left a comment
ghernandez345
left a comment
There was a problem hiding this comment.
Looks good but the bug also requires making the entire row clickable to view all hosts with that status. we're we going to do that here or another issue?
Contributor
Author
|
@ghernandez345 I actually updated the bug with that additional ask once I started working on it. I then realized it was going to be trickier than anticipated and left just the styling fix in – thanks for that reminder to revert the bug text as well. It's now (again) just the styling issue. Will file another bug for the row clickability. |
ghernandez345
approved these changes
Aug 2, 2024
jacobshandling
added a commit
that referenced
this pull request
Aug 2, 2024
## #20395 <img width="778" alt="Screenshot 2024-08-01 at 7 15 00 PM" src="https://github.com/user-attachments/assets/26fc82c0-d3e9-4e0d-b27d-82be63711fa9"> - [x] Changes file added for user-visible changes in `changes/` - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
jacobshandling
added a commit
that referenced
this pull request
Aug 2, 2024
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#20395
changes/