Skip to content

Use docker compose on CI instead of docker-compose#21017

Merged
lucasmrod merged 3 commits intomainfrom
use-docker-space-compose-on-ci
Aug 2, 2024
Merged

Use docker compose on CI instead of docker-compose#21017
lucasmrod merged 3 commits intomainfrom
use-docker-space-compose-on-ci

Conversation

@lucasmrod
Copy link
Copy Markdown
Member

After this is merged I'll cherry pick to minor-fleet-4.55.0.

jahzielv
jahzielv previously approved these changes Aug 2, 2024
roperzh
roperzh previously approved these changes Aug 2, 2024
@lukeheath
Copy link
Copy Markdown
Member

@lucasmrod Is there a story or bug associated with this PR? Trying to understand context for the change. Thanks!

@lucasmrod
Copy link
Copy Markdown
Member Author

Is there a story or bug associated with this PR? Trying to understand context for the change. Thanks!

No. Seems Github updated their runners (no docker-compose anymore) and this is blocking many PRs.

@lucasmrod
Copy link
Copy Markdown
Member Author

@lukeheath
Copy link
Copy Markdown
Member

@lucasmrod Got it, thanks!

lukeheath
lukeheath previously approved these changes Aug 2, 2024
@lucasmrod lucasmrod dismissed stale reviews from lukeheath, roperzh, and jahzielv via e13f4be August 2, 2024 20:19
@lucasmrod lucasmrod requested a review from a team as a code owner August 2, 2024 20:19
jahzielv
jahzielv previously approved these changes Aug 2, 2024
@lucasmrod lucasmrod merged commit ab7df51 into main Aug 2, 2024
@lucasmrod lucasmrod deleted the use-docker-space-compose-on-ci branch August 2, 2024 21:12
lucasmrod added a commit that referenced this pull request Aug 2, 2024
After this is merged I'll cherry pick to `minor-fleet-4.55.0`.
lucasmrod added a commit that referenced this pull request Aug 2, 2024
Backport docker compose fixes from main to `minor-fleet-v4.55.0`. (To
unblock other cherry pick PRs.)
@roperzh roperzh mentioned this pull request Aug 5, 2024
@lukeheath lukeheath mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants