Skip to content

Cherry-Pick: restricting icon size to 100kb.#32837

Merged
iansltx merged 1 commit intorc-minor-fleet-v4.74.0from
cp-32834
Sep 10, 2025
Merged

Cherry-Pick: restricting icon size to 100kb.#32837
iansltx merged 1 commit intorc-minor-fleet-v4.74.0from
cp-32834

Conversation

@ksykulev
Copy link
Copy Markdown
Contributor

fixes #32826
cherry-pick #32834

fixes #32826

## Testing

- [x] Added/updated automated tests
- [x] QA'd all new/changed functionality manually

For unreleased bug fixes in a release candidate, one of:

- [x] Confirmed that the fix is not expected to adversely impact load
test results
- [x] Alerted the release DRI if additional load testing is needed
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 54.16667% with 11 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (rc-minor-fleet-v4.74.0@bd81d77). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/service/software_title_icons.go 59.09% 6 Missing and 3 partials ⚠️
...reTitleDetailsPage/EditIconModal/EditIconModal.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.74.0   #32837   +/-   ##
=========================================================
  Coverage                          ?   63.82%           
=========================================================
  Files                             ?     2039           
  Lines                             ?   200883           
  Branches                          ?     6681           
=========================================================
  Hits                              ?   128206           
  Misses                            ?    62534           
  Partials                          ?    10143           
Flag Coverage Δ
backend 65.01% <59.09%> (?)
frontend 52.46% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iansltx iansltx changed the title restricting icon size to 100kb. Cherry-Pick: restricting icon size to 100kb. Sep 10, 2025
@iansltx iansltx merged commit 7f734a6 into rc-minor-fleet-v4.74.0 Sep 10, 2025
39 checks passed
@iansltx iansltx deleted the cp-32834 branch September 10, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants