Skip to content

Show Manage Automations disabled button with tooltip on Policies page#39392

Merged
nulmete merged 10 commits intomainfrom
nulmete/policies-manage-automations-not-visible
Feb 9, 2026
Merged

Show Manage Automations disabled button with tooltip on Policies page#39392
nulmete merged 10 commits intomainfrom
nulmete/policies-manage-automations-not-visible

Conversation

@nulmete
Copy link
Copy Markdown
Member

@nulmete nulmete commented Feb 5, 2026

Related issue: Resolves #39304 (part of #25080)

Implemented similar approach to #39302, with the difference that the list policies endpoint does not include a count, and there is a separate endpoint. I extended the count policies endpoint to include an inherited_policy_count.

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

Testing

  • Added/updated automated tests

  • QA'd all new/changed functionality manually

@nulmete nulmete requested review from a team as code owners February 5, 2026 14:21
router: InjectedRouter;
automationsConfig: IAutomationsConfig | ITeamAutomationsConfig;
availableIntegrations: IGlobalIntegrations | ITeamIntegrations;
availablePolicies: IPolicy[];
Copy link
Copy Markdown
Member Author

@nulmete nulmete Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to pass availablePolicies down to this component since it already relies on PoliciesPaginatedList to fetch the policies and paginate them within the modal.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 28.12500% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.21%. Comparing base (e62f451) to head (b357b10).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...onents/OtherWorkflowsModal/OtherWorkflowsModal.tsx 0.00% 11 Missing ⚠️
server/service/team_policies.go 56.25% 4 Missing and 3 partials ⚠️
...policies/ManagePoliciesPage/ManagePoliciesPage.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #39392   +/-   ##
=======================================
  Coverage   66.21%   66.21%           
=======================================
  Files        2432     2432           
  Lines      194792   194836   +44     
  Branches     8558     8557    -1     
=======================================
+ Hits       128972   129008   +36     
  Misses      54120    54120           
- Partials    11700    11708    +8     
Flag Coverage Δ
backend 67.98% <56.25%> (-0.01%) ⬇️
frontend 54.26% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lucasmrod
lucasmrod previously approved these changes Feb 6, 2026
juan-fdz-hawa
juan-fdz-hawa previously approved these changes Feb 9, 2026
…lmete/policies-manage-automations-not-visible
Base automatically changed from nulmete/queries-manage-automations-not-visible to main February 9, 2026 18:16
@nulmete nulmete dismissed stale reviews from juan-fdz-hawa and lucasmrod February 9, 2026 18:16

The base branch was changed.

@nulmete nulmete merged commit 65a877a into main Feb 9, 2026
50 checks passed
@nulmete nulmete deleted the nulmete/policies-manage-automations-not-visible branch February 9, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Policies page: "Manage Automations" button not visible

3 participants