Skip to content

Fleet UI: Update add software flow for patch policy#40948

Merged
RachelElysia merged 1 commit intofeat/31914-patch-policyfrom
40402-patch-add-sw-page
Mar 5, 2026
Merged

Fleet UI: Update add software flow for patch policy#40948
RachelElysia merged 1 commit intofeat/31914-patch-policyfrom
40402-patch-add-sw-page

Conversation

@RachelElysia
Copy link
Copy Markdown
Member

@RachelElysia RachelElysia commented Mar 4, 2026

Issue

Closes #40402
Parent #31914

Description

  • Removes options and advanced options from adding software pages (FMA, VPP, Android)
  • Removes options from custom package
  • Update tests to reflect new UI

Note: To be merged in the parent branch and not squashed with other contributors

Screen recording

Screenshot 2026-03-04 at 2 07 07 PM Screenshot 2026-03-04 at 2 06 59 PM Screenshot 2026-03-04 at 2 06 46 PM Screenshot 2026-03-04 at 2 06 38 PM

https://fleetdm.zoom.us/clips/share/NJ38bCYQTRKlC8Am9z7BDA

Checklist for submitter

Testing

  • Added/updated automated tests - turns out there's no automated tests on any of these components or forms. Great candidate for qa wolf IMO. Will write them up at end of sprint if time allows.
  • QA'd all new/changed functionality manually

@RachelElysia RachelElysia changed the base branch from main to feat/31914-patch-policy March 4, 2026 15:11
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feat/31914-patch-policy@fc2eb9a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...lsPage/FleetAppDetailsForm/FleetAppDetailsForm.tsx 0.00% 2 Missing ⚠️
...oftwareOptionsSelector/SoftwareOptionsSelector.tsx 33.33% 2 Missing ⚠️
...ePage/components/forms/PackageForm/PackageForm.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##             feat/31914-patch-policy   #40948   +/-   ##
==========================================================
  Coverage                           ?   66.31%           
==========================================================
  Files                              ?     2466           
  Lines                              ?   197333           
  Branches                           ?     8692           
==========================================================
  Hits                               ?   130871           
  Misses                             ?    54620           
  Partials                           ?    11842           
Flag Coverage Δ
frontend 54.27% <16.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RachelElysia RachelElysia force-pushed the 40402-patch-add-sw-page branch from 71c3e3e to a6b83a4 Compare March 4, 2026 15:49
@RachelElysia RachelElysia marked this pull request as ready for review March 4, 2026 18:48
@RachelElysia RachelElysia requested a review from a team as a code owner March 4, 2026 18:48
@RachelElysia RachelElysia changed the title [draft] Fleet UI: Update add software flow for patch policy Fleet UI: Update add software flow for patch policy Mar 4, 2026
@RachelElysia RachelElysia merged commit 9b20a32 into feat/31914-patch-policy Mar 5, 2026
16 checks passed
@RachelElysia RachelElysia deleted the 40402-patch-add-sw-page branch March 5, 2026 14:22
@cdcme cdcme mentioned this pull request Mar 11, 2026
4 tasks
cdcme added a commit that referenced this pull request Mar 13, 2026
Implements patch policies #31914 

- #40816
- #41248
- #41276
- #40948
- #40837
- #40956
- #41168
- #41171
- #40691
- #41524
- #41674

---------

Co-authored-by: Jonathan Katz <44128041+jkatz01@users.noreply.github.com>
Co-authored-by: jkatz01 <yehonatankatz@gmail.com>
Co-authored-by: RachelElysia <71795832+RachelElysia@users.noreply.github.com>
Co-authored-by: Jahziel Villasana-Espinoza <jahziel@fleetdm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FE: Add software page

2 participants