Skip to content

Update automation dropdown#41524

Merged
cdcme merged 1 commit intofeat/31914-patch-policyfrom
fix-40400-automation-dropdown
Mar 12, 2026
Merged

Update automation dropdown#41524
cdcme merged 1 commit intofeat/31914-patch-policyfrom
fix-40400-automation-dropdown

Conversation

@cdcme
Copy link
Copy Markdown
Member

@cdcme cdcme commented Mar 12, 2026 •
edited
Loading

Related issue: Resolves #40400

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects
  • If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes

Testing

  • QA'd all new/changed functionality manually
image image

@cdcme cdcme linked an issue Mar 12, 2026 that may be closed by this pull request
FE: Manage policies table page #40400
Closed
@cdcme cdcme mentioned this pull request Mar 12, 2026
Merged
4 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feat/31914-patch-policy@a2cc07f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...policies/ManagePoliciesPage/ManagePoliciesPage.tsx 0.00% 13 Missing ⚠️
Additional details and impacted files 
@@                    Coverage Diff                     @@
##             feat/31914-patch-policy   #41524   +/-   ##
==========================================================
  Coverage                           ?   66.37%           
==========================================================
  Files                              ?     2483           
  Lines                              ?   198685           
  Branches                           ?     8813           
==========================================================
  Hits                               ?   131874           
  Misses                             ?    54899           
  Partials                           ?    11912
Flag Coverage Δ
frontend 54.51% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cdcme cdcme marked this pull request as ready for review March 12, 2026 00:43
@cdcme cdcme requested a review from a team as a code owner March 12, 2026 00:43
RachelElysia
RachelElysia reviewed Mar 12, 2026
View reviewed changes
Comment thread frontend/pages/policies/ManagePoliciesPage/ManagePoliciesPage.tsx
const filterPoliciesByAutomation = (
// Client-side filtering is still needed for global policies since the
// global policies endpoint does not support automation_type. Team policies
// use the server-side automation_type query param instead.
Copy link
Copy Markdown
Member

@RachelElysia RachelElysia Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we planning on building server side filtering for automation_type? I guess there would only be other but this is gonna make the pagination super buggy to do both

Copy link
Copy Markdown
Member Author

@cdcme cdcme Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, great observation! I saw the TODO in policies.go and decided to keep this work focused. I'm thinking we can follow up on this issue later, unless you would push to do it now. Probably would want to do that in a separate PR, though, because I think it would require a bit more FE+BE changes iirc.

@RachelElysia
Copy link
Copy Markdown
Member

RachelElysia commented Mar 12, 2026

Approved code, but did not personally test

@cdcme cdcme merged commit 405ff00 into feat/31914-patch-policy Mar 12, 2026
16 checks passed
@cdcme cdcme deleted the fix-40400-automation-dropdown branch March 12, 2026 16:49
cdcme added a commit that referenced this pull request Mar 13, 2026
@cdcme @jkatz01
@RachelElysia @jahzielv
Feat/31914 patch policy (#41518)
2abacc5 
Implements patch policies #31914 

- #40816
- #41248
- #41276
- #40948
- #40837
- #40956
- #41168
- #41171
- #40691
- #41524
- #41674

---------

Co-authored-by: Jonathan Katz <44128041+jkatz01@users.noreply.github.com>
Co-authored-by: jkatz01 <yehonatankatz@gmail.com>
Co-authored-by: RachelElysia <71795832+RachelElysia@users.noreply.github.com>
Co-authored-by: Jahziel Villasana-Espinoza <jahziel@fleetdm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RachelElysia RachelElysia RachelElysia approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FE: Manage policies table page

2 participants

@cdcme @RachelElysia