Skip to content

Fleet UI: Tweaks to 31914 styling#41674

Merged
RachelElysia merged 3 commits intofeat/31914-patch-policyfrom
31914-more
Mar 13, 2026
Merged

Fleet UI: Tweaks to 31914 styling#41674
RachelElysia merged 3 commits intofeat/31914-patch-policyfrom
31914-more

Conversation

@RachelElysia
Copy link
Copy Markdown
Member

@RachelElysia RachelElysia commented Mar 13, 2026

Issue

Closes #31914

Description

  • Hide policies table count when no policies
  • Surface error message to UI
  • Arrow and no underline for info icon on read-only policy SQL
  • Show automation list for non-patch policy detail pages as well
  • Restyle the Automations list
  • Add graphics from figma and surface them in automations list
  • Update ps1 and sh graphics to be able to rescale to 24px height (use class for CSS, add missing viewbox on filesh.tsx needed to rescale)

Screenshots/screen recordings of fixes

Screenshot 2026-03-13 at 3 34 11 PM Screenshot 2026-03-13 at 3 30 55 PM
Screen.Recording.2026-03-13.at.3.30.30.PM.mov
Screen.Recording.2026-03-13.at.3.22.45.PM.mov

Testing

  • QA'd all new/changed functionality manually

@RachelElysia RachelElysia requested review from a team as code owners March 13, 2026 19:38
@RachelElysia RachelElysia changed the base branch from main to feat/31914-patch-policy March 13, 2026 19:38
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 64.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.39%. Comparing base (44ee129) to head (6e1d86a).
⚠️ Report is 57 commits behind head on feat/31914-patch-policy.

Files with missing lines Patch % Lines
...components/PolicyAutomations/PolicyAutomations.tsx 71.42% 4 Missing ⚠️
...lsPage/DeleteSoftwareModal/DeleteSoftwareModal.tsx 25.00% 3 Missing ⚠️
frontend/components/graphics/Lock.tsx 50.00% 1 Missing ⚠️
frontend/components/graphics/Settings.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           feat/31914-patch-policy   #41674      +/-   ##
===========================================================
- Coverage                    66.40%   66.39%   -0.02%     
===========================================================
  Files                         2495     2499       +4     
  Lines                       199721   199800      +79     
  Branches                      8831     8884      +53     
===========================================================
+ Hits                        132625   132655      +30     
- Misses                       55110    55159      +49     
  Partials                     11986    11986              
Flag Coverage Δ
frontend 54.40% <64.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RachelElysia RachelElysia removed the request for review from a team March 13, 2026 20:10
@RachelElysia RachelElysia merged commit 50076d1 into feat/31914-patch-policy Mar 13, 2026
16 checks passed
@RachelElysia RachelElysia deleted the 31914-more branch March 13, 2026 20:11
@cdcme cdcme mentioned this pull request Mar 13, 2026
4 tasks
cdcme added a commit that referenced this pull request Mar 13, 2026
Implements patch policies #31914 

- #40816
- #41248
- #41276
- #40948
- #40837
- #40956
- #41168
- #41171
- #40691
- #41524
- #41674

---------

Co-authored-by: Jonathan Katz <44128041+jkatz01@users.noreply.github.com>
Co-authored-by: jkatz01 <yehonatankatz@gmail.com>
Co-authored-by: RachelElysia <71795832+RachelElysia@users.noreply.github.com>
Co-authored-by: Jahziel Villasana-Espinoza <jahziel@fleetdm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Patch policy: Fleet-maintained apps

2 participants