Skip to content

Website: Make parlance match other pages#45777

Merged
mikermcneil merged 1 commit into
mainfrom
mikermcneil-patch-26
May 19, 2026
Merged

Website: Make parlance match other pages#45777
mikermcneil merged 1 commit into
mainfrom
mikermcneil-patch-26

Conversation

@mikermcneil
Copy link
Copy Markdown
Member

@mikermcneil mikermcneil commented May 19, 2026

Summary by CodeRabbit

  • Style
    • Updated the comparison table mode switch labels on the homepage for improved clarity. Mobile switch options now read "IT engineers" and "CISOs"; desktop switch options now read "For IT engineers" and "For CISOs".

Review Change Stack

@fleet-release fleet-release requested a review from eashaw May 19, 2026 01:33
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@fleet-release fleet-release added the ~ga4-annotation This label is automatically applied to certain website changes label May 19, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 60d6882b-d447-4769-a869-8e2b475b39dc

📥 Commits

Reviewing files that changed from the base of the PR and between 53650a5 and cf1548e.

📒 Files selected for processing (1)
  • website/views/pages/homepage.ejs

Walkthrough

This PR updates UI copy in the homepage comparison table mode switcher. The mobile-only button options now display "IT engineers" and "CISOs" instead of "IT" and "Security". The desktop-only options now read "For IT engineers" and "For CISOs" instead of "For IT admins" and "For security engineers". All Vue click handlers and mode-selection logic remain unchanged.

Possibly related PRs

  • fleetdm/fleet#45727: Updates website mode switch UI labels to use "IT engineers" and corresponding security-side terminology with consistent Vue selection logic.
  • fleetdm/fleet#45001: Modifies comparison-table UI selector options in the same homepage.ejs file.
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is entirely empty, missing all required sections from the template including issue reference, checklist items, testing confirmation, and other important documentation. Add a complete pull request description following the repository template, including the related issue number, relevant checklist items, and confirmation that the UI copy changes were tested.
Title check ❓ Inconclusive The title 'Website: Make parlance match other pages' is vague and generic, not clearly describing the specific UI copy changes made to the homepage comparison-table switch. Use a more specific title that describes the actual change, such as 'Update homepage comparison-table switch labels to match site terminology' or 'Refine comparison-table mode switch copy for IT engineers and CISOs'.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mikermcneil-patch-26

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mikermcneil mikermcneil merged commit 5a0e053 into main May 19, 2026
9 checks passed
@mikermcneil mikermcneil deleted the mikermcneil-patch-26 branch May 19, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

~ga4-annotation This label is automatically applied to certain website changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants