Skip to content

Website: update features comparison table on homepage#46293

Merged
eashaw merged 3 commits into
mainfrom
website-update-homepage-features-table
May 27, 2026
Merged

Website: update features comparison table on homepage#46293
eashaw merged 3 commits into
mainfrom
website-update-homepage-features-table

Conversation

@eashaw
Copy link
Copy Markdown
Contributor

@eashaw eashaw commented May 27, 2026

Changes:

  • Simplified the feature comparison table on the homepage (Removed the switch and "For CISOs" table, and reduced the list to 8 features)
  • Cleaned up unused methods and variables in the homepage page script

Summary by CodeRabbit

  • Updates
    • Streamlined the homepage comparison tables by removing several vendor and feature rows
    • Simplified vendor selection dropdowns on desktop and mobile for easier browsing
    • Removed the mobile/desktop mode switch for the IT comparison view
    • Adjusted homepage ticker behavior so the bottom ticker always animates (hero ticker removed)
    • Condensed IT comparison content, preserving the simplified "Open source" indicator

Review Change Stack

Copilot AI review requested due to automatic review settings May 27, 2026 21:09
@fleet-release fleet-release added the ~ga4-annotation This label is automatically applied to certain website changes label May 27, 2026
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

fleet-release
fleet-release previously approved these changes May 27, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 85218ecb-3ecc-459b-94ff-ebca07fe684f

📥 Commits

Reviewing files that changed from the base of the PR and between 703ace3 and 1481360.

📒 Files selected for processing (2)
  • website/assets/js/pages/homepage.page.js
  • website/views/pages/homepage.ejs
💤 Files with no reviewable changes (1)
  • website/assets/js/pages/homepage.page.js
🚧 Files skipped from review as they are similar to previous changes (1)
  • website/views/pages/homepage.ejs

Walkthrough

This PR simplifies the homepage comparison feature by consolidating from dual IT and Security comparison modes to IT only. The JavaScript data state now uses comparisonModeForIt instead of comparisonModeForSecurity, the clickSwitchComparisonMode method is removed, and clickSwitchComparisonTableColumn now only updates IT mode. The mounted lifecycle hook is simplified to call animateBottomTicker() directly, and animateHeroTicker is removed. Both desktop and mobile comparison tables are streamlined by removing several feature rows (Import/export, Remote lock and wipe, App management, Automated device compliance) and pruning vendor dropdown options.

Possibly related PRs

  • fleetdm/fleet#45777: Also modifies the homepage comparison-table mode-switch UI and related template areas around comparisonTableMode.
  • fleetdm/fleet#45001: Updates the homepage IT comparison section, including vendor selector and comparison content ordering.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is largely incomplete, missing most required checklist items from the template such as changes files, testing, database migrations, and other critical sections. Add the required checklist items from the template, including confirmation of changes files, testing performed, and other applicable sections relevant to the website update.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: updating the features comparison table on the homepage, which aligns with the primary objectives of simplifying the comparison table and removing unnecessary UI elements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch website-update-homepage-features-table

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Fleet website homepage to simplify the “Moving to Fleet?” feature comparison section by removing the audience switch / security-focused table and trimming the remaining comparison UI + script accordingly.

Changes:

  • Removed the comparison-table mode switch and deleted the “For CISOs” (security) comparison tables from the homepage template.
  • Reduced the remaining “IT” comparison table content (rows/features) and removed some previously listed competitor options from selectors.
  • Simplified the homepage page script by removing now-unused state/methods related to the deleted table/mode.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File Description
website/views/pages/homepage.ejs Removes the switch + security comparison tables and updates the remaining IT comparison table rows/selectors.
website/assets/js/pages/homepage.page.js Removes security comparison state/methods and updates mounted behavior accordingly.
Comments suppressed due to low confidence (1)

website/views/pages/homepage.ejs:359

  • The comparison table dropdown no longer offers ansible/puppet/chef (and also no longer offers tanium), but this row still contains vendor-specific branches for those values. With the current selector options, the ['puppet', 'chef', 'ansible'] branch is unreachable, which makes the template harder to maintain and can hide mistakes if the vendor list changes again.

Consider either (a) removing these vendor checks across the table now that those vendors aren’t selectable, or (b) re-adding those vendors to the selector so the conditions remain meaningful.

              <div purpose="feature-name"><p>Open source</p></div>
              <div purpose="fleet-column">
                <img class="mx-auto" alt="checkmark" purpose="checkmark" src="/images/icon-checkmark-green-16x16@2x.png">
              </div>
              <div purpose="comparison-column" v-if="['puppet', 'chef', 'ansible'].includes(comparisonModeForIt)">
                <p>Only free version</p>
              </div>
              <div purpose="comparison-column" v-else>
                <img class="mx-auto" alt="❌" purpose="red-x" src="/images/icon-emoji-x-12x12@2x.png">

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread website/assets/js/pages/homepage.page.js Outdated
Comment thread website/assets/js/pages/homepage.page.js Outdated
@eashaw eashaw merged commit 25b046c into main May 27, 2026
12 checks passed
@eashaw eashaw deleted the website-update-homepage-features-table branch May 27, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

~ga4-annotation This label is automatically applied to certain website changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants