Skip to content

Add Genesys Cloud as a macOS and Windows FMA#46250

Merged
allenhouchins merged 2 commits into
mainfrom
allenhouchins-genesys-cloud-fma
May 27, 2026
Merged

Add Genesys Cloud as a macOS and Windows FMA#46250
allenhouchins merged 2 commits into
mainfrom
allenhouchins-genesys-cloud-fma

Conversation

@allenhouchins

@allenhouchins allenhouchins commented May 27, 2026

Copy link
Copy Markdown
Member

Add Genesys Cloud to maintained apps: create input manifests for Homebrew (darwin dmg) and Winget (windows msi), add output metadata files for darwin (v2.49.25) and windows (v2.49.903.0) including installer URLs, checksums, install/uninstall script refs and a Windows upgrade code. Register the app in ee/maintained-apps/outputs/apps.json and add a frontend SVG icon component, mapping entry, and PNG asset for the software page.

Summary by CodeRabbit

  • New Features
    • Added comprehensive Genesys Cloud support for macOS (v2.49.25) and Windows (v2.49.903.0) with automated installation, updates, and full application lifecycle management.
    • Integrated Genesys Cloud branded icon into the software library interface for improved visual identification and user experience.

Review Change Stack

Add Genesys Cloud to maintained apps: create input manifests for Homebrew (darwin dmg) and Winget (windows msi), add output metadata files for darwin (v2.49.25) and windows (v2.49.903.0) including installer URLs, checksums, install/uninstall script refs and a Windows upgrade code. Register the app in ee/maintained-apps/outputs/apps.json and add a frontend SVG icon component, mapping entry, and PNG asset for the software page.
fleet-release
fleet-release previously approved these changes May 27, 2026
@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.84%. Comparing base (0c41e29) to head (da615af).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ges/SoftwarePage/components/icons/GenesysCloud.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #46250      +/-   ##
==========================================
- Coverage   66.84%   66.84%   -0.01%     
==========================================
  Files        2760     2761       +1     
  Lines      220835   220837       +2     
  Branches    11043    11043              
==========================================
+ Hits       147616   147617       +1     
- Misses      59855    59856       +1     
  Partials    13364    13364              
Flag Coverage Δ
frontend 55.79% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Replace the spaced unique_identifier "Genesys Cloud" with the compact "GenesysCloud" across input and output manifests. Updated ee/maintained-apps/inputs/winget/genesys-cloud.json, ee/maintained-apps/outputs/apps.json, and ee/maintained-apps/outputs/genesys-cloud/windows.json (including the exists/patched SQL queries) to keep identifiers consistent and ensure program lookup queries match the stored identifier.
@allenhouchins allenhouchins marked this pull request as ready for review May 27, 2026 14:22
Copilot AI review requested due to automatic review settings May 27, 2026 14:22
@allenhouchins allenhouchins requested a review from a team as a code owner May 27, 2026 14:22
@fleet-release fleet-release requested a review from eashaw May 27, 2026 14:22

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@allenhouchins allenhouchins merged commit 8f3e7d7 into main May 27, 2026
29 of 31 checks passed
@allenhouchins allenhouchins deleted the allenhouchins-genesys-cloud-fma branch May 27, 2026 14:22
@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f4ea0aae-a17d-4177-8146-68b69cac0487

📥 Commits

Reviewing files that changed from the base of the PR and between 819e3d3 and da615af.

⛔ Files ignored due to path filters (1)
  • website/assets/images/app-icon-genesys-cloud-60x60@2x.png is excluded by !**/*.png
📒 Files selected for processing (7)
  • ee/maintained-apps/inputs/homebrew/genesys-cloud.json
  • ee/maintained-apps/inputs/winget/genesys-cloud.json
  • ee/maintained-apps/outputs/apps.json
  • ee/maintained-apps/outputs/genesys-cloud/darwin.json
  • ee/maintained-apps/outputs/genesys-cloud/windows.json
  • frontend/pages/SoftwarePage/components/icons/GenesysCloud.tsx
  • frontend/pages/SoftwarePage/components/icons/index.ts

Walkthrough

This PR adds Genesys Cloud as a new maintained application across the system. It introduces Homebrew and Winget installer input configurations, registers the app in the central application index with separate darwin and windows entries, adds platform-specific maintenance definitions with embedded installation and uninstallation scripts (bash for macOS, PowerShell for Windows), and implements a React icon component wired into the frontend icon registry.

Possibly related PRs

  • fleetdm/fleet#45883: Both PRs add a new maintained app entry and extend the same registries (ee/maintained-apps/outputs/apps.json) and SOFTWARE_NAME_TO_ICON_MAP in frontend/pages/SoftwarePage/components/icons/index.ts.
  • fleetdm/fleet#45858: Both PRs extend frontend/pages/SoftwarePage/components/icons/index.ts by adding entries to the shared SOFTWARE_NAME_TO_ICON_MAP.
  • fleetdm/fleet#45404: Both PRs update the same frontend SOFTWARE_NAME_TO_ICON_MAP in frontend/pages/SoftwarePage/components/icons/index.ts by adding a new app-to-icon mapping.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch allenhouchins-genesys-cloud-fma

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants