FMA - Chrome remote desktop by harrisonravazzolo · Pull Request #46484 · fleetdm/fleet

harrisonravazzolo · 2026-05-29T19:19:48Z

Summary by CodeRabbit

New Features
- Chrome Remote Desktop is now supported on Windows: discover, install, update, and manage the app from the platform with tracked versions and install/uninstall flows.
- App listing includes descriptive metadata and a dedicated app icon for consistent UI branding.

codecov · 2026-05-29T19:23:47Z

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.80%. Comparing base (9a2333c) to head (dc2bada).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...twarePage/components/icons/ChromeRemoteDesktop.tsx	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #46484      +/-   ##
==========================================
- Coverage   66.81%   66.80%   -0.01%     
==========================================
  Files        2804     2805       +1     
  Lines      223574   223576       +2     
  Branches    11346    11481     +135     
==========================================
- Hits       149379   149359      -20     
- Misses      60641    60655      +14     
- Partials    13554    13562       +8

Flag	Coverage Δ
frontend	`56.48% <50.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

claude

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

coderabbitai · 2026-05-29T21:45:54Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 356b2459-144b-4695-84a2-9acc5f439b6a

📥 Commits

Reviewing files that changed from the base of the PR and between a8ec2c1 and dc2bada.

📒 Files selected for processing (1)

ee/maintained-apps/outputs/apps.json

Walkthrough

This pull request adds Chrome Remote Desktop as a new maintained Windows application across the entire stack. It introduces a winget input configuration defining the package metadata, registers the application in the central apps catalog, adds Windows-specific deployment configuration with SQL presence/patch queries and MSI installation scripts, and provides a React icon component for frontend display with its registration in the icon name mapping.

Possibly related PRs

fleetdm/fleet#46250: Both PRs modify frontend/pages/SoftwarePage/components/icons/index.ts by extending the shared SOFTWARE_NAME_TO_ICON_MAP (adding a new app name→icon entry: “chrome remote desktop” vs “genesys cloud”).
fleetdm/fleet#46409: Both PRs extend the same icon registry and add parallel maintained-app metadata entries (winget + windows + apps.json) for different apps.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided by the author. The description is completely empty, failing to address any required checklist items from the template.	Add a comprehensive pull request description addressing the relevant checklist items, including related issue number, testing performed, security validation, and any applicable sections from the template.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'FMA - Chrome remote desktop' directly describes the main change: adding Chrome Remote Desktop to the maintained apps system. It is concise and specific.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chrome-remote-tool-fma

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ee/maintained-apps/outputs/chrome-remote-desktop/windows.json`:
- Line 7: The patched query currently returns true when the app is not
installed; update the "patched" SQL string so it explicitly checks the app
exists AND that there are no rows with a version older than '148.0.7778.23'.
Concretely, use EXISTS(...) to verify a matching programs row (name = 'Chrome
Remote Desktop Host', publisher = 'Google LLC') and AND NOT EXISTS(...) with the
same predicate plus version_compare(version, '148.0.7778.23') < 0; reference the
"patched" JSON field, the programs table, and the version_compare(...) call when
making this change.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: beff3e69-22b8-4f25-8b9f-a0c6bc7513c4

📥 Commits

Reviewing files that changed from the base of the PR and between 9a2333c and a8ec2c1.

⛔ Files ignored due to path filters (1)

website/assets/images/app-icon-chrome-remote-desktop-60x60@2x.png is excluded by !**/*.png

📒 Files selected for processing (5)

ee/maintained-apps/inputs/winget/chrome-remote-desktop.json
ee/maintained-apps/outputs/apps.json
ee/maintained-apps/outputs/chrome-remote-desktop/windows.json
frontend/pages/SoftwarePage/components/icons/ChromeRemoteDesktop.tsx
frontend/pages/SoftwarePage/components/icons/index.ts

coderabbitai · 2026-05-29T21:45:57Z

+      "version": "148.0.7778.23",
+      "queries": {
+        "exists": "SELECT 1 FROM programs WHERE name = 'Chrome Remote Desktop Host' AND publisher = 'Google LLC';",
+        "patched": "SELECT 1 WHERE NOT EXISTS (SELECT 1 FROM programs WHERE name = 'Chrome Remote Desktop Host' AND publisher = 'Google LLC' AND version_compare(version, '148.0.7778.23') < 0);"


⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Fix the patched query logic.

The current patched query will incorrectly return 1 (patched) when the application is not installed at all, because NOT EXISTS (SELECT 1 FROM programs WHERE ... version < '148.0.7778.23') is true when there are zero matching rows.

The query should verify that the app is installed AND up-to-date.

🔧 Proposed fix

- "patched": "SELECT 1 WHERE NOT EXISTS (SELECT 1 FROM programs WHERE name = 'Chrome Remote Desktop Host' AND publisher = 'Google LLC' AND version_compare(version, '148.0.7778.23') < 0);" + "patched": "SELECT 1 FROM programs WHERE name = 'Chrome Remote Desktop Host' AND publisher = 'Google LLC' AND version_compare(version, '148.0.7778.23') >= 0;"

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ee/maintained-apps/outputs/chrome-remote-desktop/windows.json` at line 7, The patched query currently returns true when the app is not installed; update the "patched" SQL string so it explicitly checks the app exists AND that there are no rows with a version older than '148.0.7778.23'. Concretely, use EXISTS(...) to verify a matching programs row (name = 'Chrome Remote Desktop Host', publisher = 'Google LLC') and AND NOT EXISTS(...) with the same predicate plus version_compare(version, '148.0.7778.23') < 0; reference the "patched" JSON field, the programs table, and the version_compare(...) call when making this change.

## Summary by CodeRabbit * **New Features** * Chrome Remote Desktop is now supported on Windows with integrated package management. Users can discover, install, and manage the application directly through the platform with full tracking and automatic update capabilities. The application includes proper UI branding and Windows installation integration.  [![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/fleetdm/fleet/pull/46484?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)   --------- Co-authored-by: Allen Houchins <32207388+allenhouchins@users.noreply.github.com>

add chrome remost desktop - windows

7ad6b2c

harrisonravazzolo temporarily deployed to Docker Hub May 29, 2026 19:19 — with GitHub Actions Inactive

Merge branch 'main' into chrome-remote-tool-fma

8efbee4

harrisonravazzolo temporarily deployed to Docker Hub May 29, 2026 20:46 — with GitHub Actions Inactive

Update apps.json

af79641

harrisonravazzolo temporarily deployed to Docker Hub May 29, 2026 21:12 — with GitHub Actions Inactive

harrisonravazzolo marked this pull request as ready for review May 29, 2026 21:38

harrisonravazzolo requested a review from a team as a code owner May 29, 2026 21:38

Merge branch 'main' into chrome-remote-tool-fma

a8ec2c1

fleet-release requested review from allenhouchins and eashaw May 29, 2026 21:38

claude Bot reviewed May 29, 2026

View reviewed changes

harrisonravazzolo temporarily deployed to Docker Hub May 29, 2026 21:38 — with GitHub Actions Inactive

coderabbitai Bot reviewed May 29, 2026

View reviewed changes

Update description for Chrome Remote Desktop

dc2bada

fleet-release approved these changes May 29, 2026

View reviewed changes

allenhouchins temporarily deployed to Docker Hub May 29, 2026 21:58 — with GitHub Actions Inactive

allenhouchins approved these changes May 29, 2026

View reviewed changes

allenhouchins merged commit cf4d869 into main May 29, 2026
16 of 17 checks passed

allenhouchins deleted the chrome-remote-tool-fma branch May 29, 2026 21:59

This was referenced Jun 3, 2026

Update Fleet-maintained apps #46697

Closed

Add Microsoft Office as a Fleet-maintained app for Windows #43938

Merged

Add Microsoft .NET Runtime 8 & 10 as Windows FMAs #46877

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

FMA - Chrome remote desktop#46484

FMA - Chrome remote desktop#46484
allenhouchins merged 5 commits into
mainfrom
chrome-remote-tool-fma

harrisonravazzolo commented May 29, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

codecov Bot commented May 29, 2026 •

edited

Loading

Uh oh!

claude Bot left a comment

Uh oh!

coderabbitai Bot commented May 29, 2026 •

edited

Loading

Review failed

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot May 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

harrisonravazzolo commented May 29, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

codecov Bot commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

Claude Code Review

Uh oh!

coderabbitai Bot commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Possibly related PRs

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot May 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

harrisonravazzolo commented May 29, 2026 •

edited by coderabbitai Bot

Loading

codecov Bot commented May 29, 2026 •

edited

Loading

coderabbitai Bot commented May 29, 2026 •

edited

Loading