Add Windows FMAs (Letter C)#47732
Conversation
…herry Keys, Colour Contrast Analyser, Cribl Edge
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
Pull request overview
This PR expands Fleet’s Windows Fleet-maintained app (FMA) catalog as part of the PatchMyPC parity sweep (Letter C), adding new winget-backed MSI apps and wiring up corresponding Software page icons.
Changes:
- Added 4 new Windows winget FMA input definitions (Chef Workstation, Cherry Keys, Colour Contrast Analyser, Cribl Edge).
- Added generated Windows output manifests for those apps (installer URLs, hashes, detection queries, install/uninstall script refs) and updated the
apps.jsoncatalog index. - Added new Software page icon components and mapped them for Chef Workstation, Cherry Keys, and Cribl Edge (Colour Contrast Analyser icon mapping already exists).
Reviewed changes
Copilot reviewed 13 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/pages/SoftwarePage/components/icons/index.ts | Imports new icon components and maps software-name keys to icons. |
| frontend/pages/SoftwarePage/components/icons/ChefWorkstation.tsx | Adds Chef Workstation icon component (embedded PNG-in-SVG). |
| frontend/pages/SoftwarePage/components/icons/CherryKeys.tsx | Adds Cherry Keys icon component (embedded PNG-in-SVG). |
| frontend/pages/SoftwarePage/components/icons/CriblEdge.tsx | Adds Cribl Edge icon component (embedded PNG-in-SVG). |
| ee/maintained-apps/inputs/winget/chef-workstation.json | Adds winget input definition for Chef Workstation (custom exists_query). |
| ee/maintained-apps/inputs/winget/cherry-keys.json | Adds winget input definition for Cherry Keys (fuzzy_match_name pattern). |
| ee/maintained-apps/inputs/winget/colour-contrast-analyser.json | Adds winget input definition for Colour Contrast Analyser (explicit program_publisher). |
| ee/maintained-apps/inputs/winget/cribl-edge.json | Adds winget input definition for Cribl Edge. |
| ee/maintained-apps/outputs/chef-workstation/windows.json | Adds generated Windows manifest (queries, scripts, hash, upgrade code). |
| ee/maintained-apps/outputs/cherry-keys/windows.json | Adds generated Windows manifest (queries, scripts, hash, upgrade code). |
| ee/maintained-apps/outputs/colour-contrast-analyser/windows.json | Adds generated Windows manifest (queries, scripts, hash, upgrade code). |
| ee/maintained-apps/outputs/cribl-edge/windows.json | Adds generated Windows manifest (queries, scripts, hash, upgrade code). |
| ee/maintained-apps/outputs/apps.json | Registers the new Windows FMAs in the catalog index. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #47732 +/- ##
==========================================
- Coverage 67.21% 67.21% -0.01%
==========================================
Files 3630 3633 +3
Lines 229526 229532 +6
Branches 11957 11810 -147
==========================================
- Hits 154273 154270 -3
- Misses 61389 61396 +7
- Partials 13864 13866 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
WalkthroughFour new Windows applications—Chef Workstation, Cherry Keys, Colour Contrast Analyser, and Cribl Edge—are added to the maintained-apps catalog. Each app receives a Winget input JSON manifest (slug, package identifier, installer metadata, default category), a versioned output Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
This pull request adds support for three new Windows applications—Chef Workstation, Cherry Keys, and Colour Contrast Analyser—along with Cribl Edge, to the maintained apps system. It introduces their metadata, installation/uninstallation scripts, and icon assets, ensuring these apps can be managed and displayed within the platform.
New Windows Application Support:
Chef Workstation(chef-workstation.json), including detection queries and categorization as a Developer tool.Cherry Keys(cherry-keys.json), with fuzzy name matching and categorized as a Utility.Colour Contrast Analyser(colour-contrast-analyser.json), specifying publisher and categorized as a Utility.Cribl Edge(cribl-edge.json), with detection queries and categorized as a Developer tool.Application Output and Versioning:
chef-workstation/windows.jsoncherry-keys/windows.jsoncolour-contrast-analyser/windows.jsoncribl-edge/windows.jsonApp Catalog Updates:
apps.jsonto include the new Windows apps, each with a description and unique identifier for catalog display. [1] [2] [3]UI/Icon Assets:
ChefWorkstation.tsx).