Skip to content

Add Windows FMAs (letter B): 5 apps#48950

Merged
allenhouchins merged 2 commits into
mainfrom
add-windows-fmas-letter-b
Jul 8, 2026
Merged

Add Windows FMAs (letter B): 5 apps#48950
allenhouchins merged 2 commits into
mainfrom
add-windows-fmas-letter-b

Conversation

@allenhouchins

@allenhouchins allenhouchins commented Jul 8, 2026

Copy link
Copy Markdown
Member

Related issue: N/A — part of the Windows Fleet-maintained apps catalog expansion (letter B batch; follows #48872 and #48881).

Adds six new Windows Fleet-maintained apps:

App winget package Installer Notes
BandiView Bandisoft.BandiView EXE (NSIS-style), machine, x64 Unversioned InstallerUrl → ignore_hash (URL verified to serve the binary reliably without Referer tricks). DisplayName "BandiView" stable across releases.
BleachBit BleachBit.BleachBit EXE (NsisMultiUser), machine, x86 Install script passes the case-sensitive /allusers /S — without /allusers the NsisMultiUser installer's scope is ambiguous. winget declares a VCRedist 2010 x86 dependency Fleet can't satisfy; noted as a caveat.
Bulk Crap Uninstaller Klocman.BulkCrapUninstaller EXE (Inno), machine, x86 ARP DisplayName is versioned ("BCUninstaller 6.2.0.0") and never matches the friendly name, so unique_identifier "BCUninstaller" + fuzzy_match_name. Registry version is 4-part vs winget's "6.2" — version_compare pads, verified consistent.
BrowserStackLocal BrowserStack.BrowserStackLocal MSI (WiX), machine, x64 Clean MSI (ALLUSERS=1, identity verified via msiinfo). Unversioned InstallerUrl → ignore_hash.
Burp Suite Professional PortSwigger.BurpSuite.Professional EXE (install4j), machine, x64 Mirrors the existing Burp Suite Community FMA: -q -Dinstall4j.suppressUnattendedReboot=true plus the load-bearing -dir into Program Files (install4j defaults to per-user otherwise). DisplayName is versioned without "Edition" ("Burp Suite Professional 2026.3.3"), unlike Community — fuzzy pattern Burp Suite Professional % can't collide with Community's.
Bytello Share Bytello.BytelloShare EXE (NSIS), machine, x86 Uses the nullsoft agent=d variant whose ARP identity ("Bytello Share" / publisher "Bytello Share") matches real-world inventory; the zip variant registers a different name ("BytelloShare") and its nested-MSI path is version-pinned and already stale. Vendor URL is a latest-pointer already ahead of winget → ignore_hash. Note: the input says installer_type: "msi" — the ingester classifies this nullsoft entry as msi because its URL has no file extension (vendor-type → URL-extension → machine-scope fallback chain in ingester.go); the custom scripts handle the actual NSIS exe.

Considered but not added (recorded in the workstream tracker):

  • Bambu Studio (Bambulab.Bambustudio): the uninstaller shows a keep-user-data confirmation dialog even with /S (deployment guides work around it with Send-Keys, impossible in a SYSTEM session) — same failure class that disqualified Adobe AIR in the letter A batch.
  • Bridge Designer (StephenRessler.BridgeDesigner): installer URL 404s (file removed from SourceForge) and the desktop product was discontinued July 1, 2026 in favor of a browser-based edition.
  • BurnAware Free (Burnaware.BurnAwareFree): the vendor deletes each old release URL — the winget-pinned installer already redirects to their homepage, so pinned downloads break every release cycle.

Registry identities were verified per app (msiinfo Property tables for MSIs; vendor installer sources, winget AppsAndFeaturesEntries, and uninstall-database corroboration for EXEs). Installer SHAs verified against manifests where URLs are version-pinned; unversioned URLs use ignore_hash per the TeamViewer/Chrome precedent. Icons generated via tools/software/icons/generate-icons.sh.

Checklist for submitter

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.
  • Timeouts are implemented and retries are limited to avoid infinite loops

Testing

  • QA'd all new/changed functionality manually (relying on the FMA CI validator for Windows install/uninstall validation)

Summary by CodeRabbit

  • New Features

    • Added support for several new Windows apps, including BandiView, BleachBit, BrowserStackLocal, Bulk Crap Uninstaller, and Burp Suite Professional.
    • Added matching app icons so these products now display correctly in the software interface.
  • Bug Fixes

    • Improved install and uninstall handling for the newly supported apps, including quieter installs and more reliable removal flows.
    • Added broader detection logic to better recognize installed versions and avoid duplicate installs.

fleet-release
fleet-release previously approved these changes Jul 8, 2026
@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.11%. Comparing base (646ebd0) to head (1133755).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
.../pages/SoftwarePage/components/icons/Bandiview.tsx 50.00% 1 Missing ⚠️
.../pages/SoftwarePage/components/icons/Bleachbit.tsx 50.00% 1 Missing ⚠️
...oftwarePage/components/icons/Browserstacklocal.tsx 50.00% 1 Missing ⚠️
...twarePage/components/icons/BulkCrapUninstaller.tsx 50.00% 1 Missing ⚠️
...arePage/components/icons/BurpSuiteProfessional.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #48950      +/-   ##
==========================================
- Coverage   68.11%   68.11%   -0.01%     
==========================================
  Files        3709     3714       +5     
  Lines      235099   235109      +10     
  Branches    12352    12352              
==========================================
+ Hits       160129   160134       +5     
- Misses      60593    60598       +5     
  Partials    14377    14377              
Flag Coverage Δ
frontend 59.27% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The vendor URL already serves 5.13.1.4288 while the only winget manifest
ever published says 5.13.0.4246 (validator version check failed). Unlike
other ignore_hash FMAs (TeamViewer, Chrome), this package's manifest is
not actively maintained, so the installed version would chronically
differ from the advertised one.
@allenhouchins allenhouchins changed the title Add Windows FMAs (letter B): 6 apps Add Windows FMAs (letter B): 5 apps Jul 8, 2026
@allenhouchins

Copy link
Copy Markdown
Member Author

Validation results: 5/6 — Bytello Share dropped (1133755)

Bytello Share installed and was detected fine, but the version check failed: the vendor's latest-pointer URL installs 5.13.1.4288 while the winget manifest (the only version ever published for that package) pins 5.13.0.4246. Latest-pointer URLs are workable when the winget manifest is actively maintained (TeamViewer, Chrome), but this package's manifest is effectively abandoned, so the installed version would chronically differ from what the catalog advertises. Dropped and recorded in the tracker.

The remaining 5 (BandiView, BleachBit, Bulk Crap Uninstaller, BrowserStackLocal, Burp Suite Professional) all passed — the 3 'warnings' are the benign no-new-top-level-dir-in-Program-Files notices for x86/(x86)-path installs.

@allenhouchins allenhouchins marked this pull request as ready for review July 8, 2026 15:52
@allenhouchins allenhouchins requested a review from a team as a code owner July 8, 2026 15:52
Copilot AI review requested due to automatic review settings July 8, 2026 15:52
@fleet-release fleet-release requested a review from eashaw July 8, 2026 15:52
@allenhouchins allenhouchins merged commit 2708df6 into main Jul 8, 2026
31 of 32 checks passed
@allenhouchins allenhouchins deleted the add-windows-fmas-letter-b branch July 8, 2026 15:53
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4462cbfb-b482-451a-b7a5-c0c87e43df7e

📥 Commits

Reviewing files that changed from the base of the PR and between cb09b42 and 1133755.

⛔ Files ignored due to path filters (5)
  • website/assets/images/app-icon-bandiview-60x60@2x.png is excluded by !**/*.png
  • website/assets/images/app-icon-bleachbit-60x60@2x.png is excluded by !**/*.png
  • website/assets/images/app-icon-browserstacklocal-60x60@2x.png is excluded by !**/*.png
  • website/assets/images/app-icon-bulk-crap-uninstaller-60x60@2x.png is excluded by !**/*.png
  • website/assets/images/app-icon-burp-suite-professional-60x60@2x.png is excluded by !**/*.png
📒 Files selected for processing (25)
  • ee/maintained-apps/inputs/winget/bandiview.json
  • ee/maintained-apps/inputs/winget/bleachbit.json
  • ee/maintained-apps/inputs/winget/browserstacklocal.json
  • ee/maintained-apps/inputs/winget/bulk-crap-uninstaller.json
  • ee/maintained-apps/inputs/winget/burp-suite-professional.json
  • ee/maintained-apps/inputs/winget/scripts/bandiview_install.ps1
  • ee/maintained-apps/inputs/winget/scripts/bandiview_uninstall.ps1
  • ee/maintained-apps/inputs/winget/scripts/bleachbit_install.ps1
  • ee/maintained-apps/inputs/winget/scripts/bleachbit_uninstall.ps1
  • ee/maintained-apps/inputs/winget/scripts/bulk-crap-uninstaller_install.ps1
  • ee/maintained-apps/inputs/winget/scripts/bulk-crap-uninstaller_uninstall.ps1
  • ee/maintained-apps/inputs/winget/scripts/burp_suite_professional_install.ps1
  • ee/maintained-apps/inputs/winget/scripts/burp_suite_professional_uninstall.ps1
  • ee/maintained-apps/outputs/apps.json
  • ee/maintained-apps/outputs/bandiview/windows.json
  • ee/maintained-apps/outputs/bleachbit/windows.json
  • ee/maintained-apps/outputs/browserstacklocal/windows.json
  • ee/maintained-apps/outputs/bulk-crap-uninstaller/windows.json
  • ee/maintained-apps/outputs/burp-suite-professional/windows.json
  • frontend/pages/SoftwarePage/components/icons/Bandiview.tsx
  • frontend/pages/SoftwarePage/components/icons/Bleachbit.tsx
  • frontend/pages/SoftwarePage/components/icons/Browserstacklocal.tsx
  • frontend/pages/SoftwarePage/components/icons/BulkCrapUninstaller.tsx
  • frontend/pages/SoftwarePage/components/icons/BurpSuiteProfessional.tsx
  • frontend/pages/SoftwarePage/components/icons/index.ts

Walkthrough

This PR adds five new maintained apps for winget/Windows: BandiView, BleachBit, BrowserStackLocal, Bulk Crap Uninstaller, and Burp Suite Professional. Each app gets a winget input JSON manifest specifying installer metadata and script paths, dedicated PowerShell install/uninstall scripts handling silent installation, registry-based uninstall detection, and exit-code handling, a corresponding generated output JSON embedding version detection queries and script references, and a new entry in the apps.json registry. Additionally, new React SVG icon components are added for each app and wired into the frontend's SOFTWARE_NAME_TO_ICON_MAP lookup used on the Software page.

Possibly related PRs

  • fleetdm/fleet#47536: Updates the same SOFTWARE_NAME_TO_ICON_MAP lookup structure in the icons index module with new app-to-icon registrations.
  • fleetdm/fleet#47732: Extends the same icons index file's SOFTWARE_NAME_TO_ICON_MAP with additional app icon mappings, following the same pattern for different products.
  • fleetdm/fleet#48881: Modifies the same icon-mapping machinery in frontend/pages/SoftwarePage/components/icons/index.ts, adding new software-name-to-icon entries.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-windows-fmas-letter-b

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Expands Fleet’s Windows Fleet-maintained apps (FMA) catalog for the “B” batch by adding new Winget ingester inputs, generated Windows outputs (install/patch queries + installer metadata + embedded scripts), and corresponding Software page icons so the apps render with proper branding in the UI.

Changes:

  • Add 5 new Windows FMAs: BandiView, BleachBit, Bulk Crap Uninstaller, BrowserStackLocal, Burp Suite Professional (inputs + generated outputs + catalog index).
  • Add 5 new Software page icon components and wire them into the icon map for loose-prefix matching.
  • Add install/uninstall PowerShell scripts (and embed them into outputs via script refs) where needed for silent install/uninstall behavior.

Reviewed changes

Copilot reviewed 25 out of 30 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
frontend/pages/SoftwarePage/components/icons/index.ts Registers new icon components and maps normalized software names to those icons.
frontend/pages/SoftwarePage/components/icons/Bandiview.tsx Adds BandiView icon component.
frontend/pages/SoftwarePage/components/icons/Bleachbit.tsx Adds BleachBit icon component.
frontend/pages/SoftwarePage/components/icons/Browserstacklocal.tsx Adds BrowserStackLocal icon component.
frontend/pages/SoftwarePage/components/icons/BulkCrapUninstaller.tsx Adds Bulk Crap Uninstaller icon component.
frontend/pages/SoftwarePage/components/icons/BurpSuiteProfessional.tsx Adds Burp Suite Professional icon component.
ee/maintained-apps/outputs/bandiview/windows.json Generated Windows FMA output for BandiView (queries/installer metadata/script refs).
ee/maintained-apps/outputs/bleachbit/windows.json Generated Windows FMA output for BleachBit (queries/installer metadata/script refs).
ee/maintained-apps/outputs/bulk-crap-uninstaller/windows.json Generated Windows FMA output for Bulk Crap Uninstaller (queries/installer metadata/script refs).
ee/maintained-apps/outputs/browserstacklocal/windows.json Generated Windows FMA output for BrowserStackLocal (queries/installer metadata/MSI upgrade code).
ee/maintained-apps/outputs/burp-suite-professional/windows.json Generated Windows FMA output for Burp Suite Professional (queries/installer metadata/script refs).
ee/maintained-apps/outputs/apps.json Adds the new apps to the global maintained-apps catalog index.
ee/maintained-apps/inputs/winget/bandiview.json Adds Winget ingester input for BandiView.
ee/maintained-apps/inputs/winget/bleachbit.json Adds Winget ingester input for BleachBit.
ee/maintained-apps/inputs/winget/bulk-crap-uninstaller.json Adds Winget ingester input for Bulk Crap Uninstaller.
ee/maintained-apps/inputs/winget/browserstacklocal.json Adds Winget ingester input for BrowserStackLocal (MSI, ignore_hash).
ee/maintained-apps/inputs/winget/burp-suite-professional.json Adds Winget ingester input for Burp Suite Professional (custom scripts, fuzzy match).
ee/maintained-apps/inputs/winget/scripts/bandiview_install.ps1 Silent install script for BandiView.
ee/maintained-apps/inputs/winget/scripts/bandiview_uninstall.ps1 Silent uninstall script for BandiView via registry uninstall entry.
ee/maintained-apps/inputs/winget/scripts/bleachbit_install.ps1 Silent install script for BleachBit with NsisMultiUser all-users switch.
ee/maintained-apps/inputs/winget/scripts/bleachbit_uninstall.ps1 Silent uninstall script for BleachBit via registry uninstall entry.
ee/maintained-apps/inputs/winget/scripts/bulk-crap-uninstaller_install.ps1 Silent install script for Bulk Crap Uninstaller (Inno Setup).
ee/maintained-apps/inputs/winget/scripts/bulk-crap-uninstaller_uninstall.ps1 Silent uninstall script for Bulk Crap Uninstaller (Inno Setup) via registry uninstall entry.
ee/maintained-apps/inputs/winget/scripts/burp_suite_professional_install.ps1 Silent install script for Burp Suite Professional (install4j) with explicit machine install dir.
ee/maintained-apps/inputs/winget/scripts/burp_suite_professional_uninstall.ps1 Uninstall script for Burp Suite Professional (install4j) with process cleanup and arg normalization.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +956 to +962
{
"name": "BandiView",
"slug": "bandiview/windows",
"platform": "windows",
"unique_identifier": "BandiView",
"description": "BandiView is a fast image viewer supporting a wide range of photo and comic formats."
},
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants