Skip to content

Patch when closed: frontend - #50437

Merged
cdcme merged 6 commits into
feat/39962-patch-when-closedfrom
49419-patch-when-closed-ui
Aug 4, 2026
Merged

Patch when closed: frontend#50437
cdcme merged 6 commits into
feat/39962-patch-when-closedfrom
49419-patch-when-closed-ui

Conversation

@cdcme

@cdcme cdcme commented Aug 3, 2026

Copy link
Copy Markdown
Member

Related issue: Resolves #49419

Adds the UI for patching Fleet-maintained apps when the app is closed. The patch toggle becomes a Deploy control with Force install and Patch checkboxes. Checking Patch reveals a radio group: Patch when app is closed, Force patch, or End user initiated. The control appears in the Add software flow, a new Deploy modal, and the edit-policy page. The change also adds skipped-install copy in the activity feed and install details, a Self-service toggle for Fleet-maintained apps, and GitOps and Premium gating.

The PR also includes backend changes that expose the patch policy's continuous-automation state and a Fleet-maintained app's install query in the API. The UI reads both to show the correct Deploy options, so they ship in one PR.

Testing

  • Added/updated automated tests
  • QA'd all new/changed functionality manually

Eng QA walkthrough part 1, part 2

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.88889% with 33 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feat/39962-patch-when-closed@345eb05). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...lsPage/FleetAppDetailsForm/FleetAppDetailsForm.tsx 72.72% 12 Missing ⚠️
frontend/services/entities/software.ts 0.00% 4 Missing ⚠️
...olicyAutomationsFields/PolicyAutomationsFields.tsx 95.31% 3 Missing ⚠️
...edAppDetailsPage/FleetMaintainedAppDetailsPage.tsx 85.71% 2 Missing ⚠️
...ftwareTitleDetailsPage/DeployModal/DeployModal.tsx 97.10% 2 Missing ⚠️
...lsPage/SoftwareSummaryCard/SoftwareSummaryCard.tsx 71.42% 2 Missing ⚠️
.../SoftwareDetailsSummary/SoftwareDetailsSummary.tsx 50.00% 2 Missing ⚠️
...mponents/forms/SoftwareVppForm/SoftwareVppForm.tsx 50.00% 2 Missing ⚠️
...policies/edit/components/PolicyForm/PolicyForm.tsx 92.30% 1 Missing and 1 partial ⚠️
...ms/AdvancedOptionsFields/AdvancedOptionsFields.tsx 75.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@                       Coverage Diff                       @@
##             feat/39962-patch-when-closed   #50437   +/-   ##
===============================================================
  Coverage                                ?   67.99%           
===============================================================
  Files                                   ?     3897           
  Lines                                   ?   248995           
  Branches                                ?    13171           
===============================================================
  Hits                                    ?   169295           
  Misses                                  ?    64476           
  Partials                                ?    15224           
Flag Coverage Δ
backend 69.28% <100.00%> (?)
frontend 61.05% <88.85%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cdcme
cdcme marked this pull request as ready for review August 3, 2026 18:34
@cdcme
cdcme requested review from a team as code owners August 3, 2026 18:34
Comment thread server/fleet/maintained_apps.go
Comment thread frontend/interfaces/software.ts Outdated
Comment thread frontend/pages/SoftwarePage/components/forms/SoftwareDeploySelector/index.ts Outdated

@RachelElysia RachelElysia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, to not block but if you can followup on some of the nits I flagged, that would be great. This nit will likely bug me if we keep it in the code.

@cdcme
cdcme merged commit 885540e into feat/39962-patch-when-closed Aug 4, 2026
35 of 39 checks passed
@cdcme
cdcme deleted the 49419-patch-when-closed-ui branch August 4, 2026 17:47
@jkatz01 jkatz01 mentioned this pull request Aug 4, 2026
rachaelshaw pushed a commit that referenced this pull request Aug 6, 2026
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #49420

Adds documentation for the new automatic_install_query that the `GET
/api/v1/fleet/software/fleet_maintained_apps/1` endpoint requires for
the feature.
#50437 (comment)

`software_title.packages[].patch_policy.continuous_automations_enabled`
was also added. I left it out of this PR because nothing documents the
`patch_policy` object currently, it is null in all examples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Patch when closed: Deploy modal, software title details, activity copy, and Self-service toggle

3 participants