Skip to content

Remove dart:html from build_release.sh#1975

Merged
DanTup merged 2 commits intoflutter:masterfrom
DanTup:build-flutter-release
May 18, 2020
Merged

Remove dart:html from build_release.sh#1975
DanTup merged 2 commits intoflutter:masterfrom
DanTup:build-flutter-release

Conversation

@DanTup
Copy link
Copy Markdown
Contributor

@DanTup DanTup commented May 16, 2020

I think this is all correct. We no longer need to build the dart:html version, nor do we need to do gymnastics to put the Flutter version in a folder and change its index to flutter.html.

With this change, running the "Run Server with Release Build" launch config from VS Code seems to work as expected.

@DanTup DanTup requested review from jacob314 and kenzieschmoll May 16, 2020 19:09
@DanTup
Copy link
Copy Markdown
Contributor Author

DanTup commented May 16, 2020

(also removed the old web handler for mapping /packages/ to /pack/ - a folder that no longer exists without the HTML version)

Copy link
Copy Markdown
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify that running the publish.sh script, and then running dart devtools/bin/devtools.dart launches the flutter web app as expected?

@DanTup
Copy link
Copy Markdown
Contributor Author

DanTup commented May 18, 2020

Yep, it launches fine for me. Previously we were still building the Flutter version at /flutter.html so it would serve up the (missing) dart:html version.

FWIW, if using VS Code there's a launch config "Run Server with Release Build" that will do both steps (though just build_release.sh instead of publish.sh) plus automatically launch the browser and attach the debugger to the server which may be convenient for general testing of release builds (it doesn't modify the gitignore though, so when actually ready to publish you'd need to use the publish script).

@kenzieschmoll
Copy link
Copy Markdown
Member

Awesome. Thanks for the fix!

@kenzieschmoll
Copy link
Copy Markdown
Member

lgtm_army

@DanTup DanTup merged commit 75a5d05 into flutter:master May 18, 2020
@DanTup DanTup deleted the build-flutter-release branch May 18, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants