Skip to content

Remove dart:html from build_release.sh #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanTup merged 2 commits into from
May 18, 2020
Merged

Remove dart:html from build_release.sh #1975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
530b80f
Remove dart:html from build_release.sh
DanTup May 16, 2020
1a5710d
Remove handler for /pack/ for dart:html build
DanTup May 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions packages/devtools_server/lib/src/external_handlers.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,32 +80,11 @@ Future<shelf.Handler> defaultHandler(
debugProxyHandler = proxyHandler(Uri.parse('http://localhost:$webPort/'));
}

// The packages folder is renamed in the pub package so this handler serves
// out of the `pack` folder.
Handler packHandler;
if (!debugMode) {
final packFolder = path.join(packageDir, 'build', 'pack');
if (Directory(packFolder).existsSync()) {
packHandler = createStaticHandler(
packFolder,
defaultDocument: 'index.html',
);
}
}

final sseHandler = SseHandler(Uri.parse('/api/sse'))
..connections.rest.listen(clients.acceptClient);

// Make a handler that delegates based on path.
final handler = (shelf.Request request) {
if (!debugMode) {
if (packHandler != null && request.url.path.startsWith('packages/')) {
// request.change here will strip the `packages` prefix from the path
// so it's relative to packHandler's root.
return packHandler(request.change(path: 'packages'));
}
}

if (request.url.path.startsWith('api/sse')) {
return sseHandler.handler(request);
}
Expand Down
17 changes: 1 addition & 16 deletions tool/build_release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,23 +11,8 @@ pushd packages/devtools_app
rm -rf build
rm -rf ../devtools/build
flutter pub get
flutter pub run build_runner build -o web:build --release
mv ./build/packages ./build/pack

# move release to the devtools package from the devtools_app package for deployment
mv build ../devtools

# Build the flutter release of the app as well.

rm -rf build
flutter build web --dart-define=FLUTTER_WEB_USE_SKIA=true --no-tree-shake-icons
mkdir build/web/flutter
mv build/web/main.* build/web/flutter/

sed 's|main.dart.js|flutter\/main.dart.js|' build/web/index.html > build/web/tmp.html
sed 's|<head>|<head><style>.legacy-dart {visibility: hidden;}</style>|' build/web/tmp.html > build/web/flutter.html
rm build/web/index.html build/web/tmp.html

mv build/web/* ../devtools/build/
mv build/web ../devtools/build

popd