Skip to content

Fix RenderFlex overflow error in Inspector controls - #8851

Merged
keertip merged 2 commits into
flutter:masterfrom
keertip:test
Feb 5, 2025
Merged

Fix RenderFlex overflow error in Inspector controls#8851
keertip merged 2 commits into
flutter:masterfrom
keertip:test

Conversation

@keertip

@keertip keertip commented Feb 5, 2025

Copy link
Copy Markdown
Contributor

Fixes #8815

@keertip
keertip requested a review from a team as a code owner February 5, 2025 21:22
@keertip
keertip requested review from kenzieschmoll and removed request for a team February 5, 2025 21:22
final v2.InspectorController? controller;

static const minScreenWidthForTextBeforeTruncating = 800.0;
static const minScreenWidthForTextBeforeScaling = 550.0;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we revert the change to this file? I think this is for the left aligned inspector controls which we didn't need to adjust.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, done!

@kenzieschmoll kenzieschmoll left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment.

@keertip
keertip merged commit 9acf7d6 into flutter:master Feb 5, 2025
@keertip
keertip deleted the test branch February 5, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RenderFlex overflow error on inspector controls for narrow screen

2 participants