Skip to content

handle null functions key in cpu samples #8940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakemac53 merged 3 commits into from
Feb 26, 2025
Merged

handle null functions key in cpu samples #8940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ded5ef
handle null functions key in cpu samples
jakemac53 Feb 24, 2025
4275920
fix false postive diagnostics
jakemac53 Feb 24, 2025
7bb58bf
remove unused import
jakemac53 Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/devtools_app/lib/src/screens/profiler/cpu_profile_model.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1223,7 +1223,7 @@ class _CpuProfileTimelineTree {
if (isCodeTree) {
return _code.function!;
}
final function = samples.functions![index].function;
final function = samples.functions?[index].function;
if (function is vm_service.FuncRef ||
function is vm_service.NativeFunction) {
return function;
Expand Down Expand Up @@ -1263,7 +1263,7 @@ class _CpuProfileTimelineTree {
// critical since this is only displayed when VM developer mode is
// enabled.
(_function as vm_service.FuncRef?)?.location?.script?.uri
: samples.functions![index].resolvedUrl;
: samples.functions?[index].resolvedUrl;

int? get sourceLine {
final function = _function;
Expand Down
12 changes: 12 additions & 0 deletions packages/devtools_app/test/screens/cpu_profiler/cpu_profile_model_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,18 @@ void main() {
);
});

test('converts samples with no functions regression test', () {
expect(
// False positive for this lint, it is used by the matcher.
// ignore: discarded_futures
CpuProfileData.generateFromCpuSamples(
isolateId: goldenSamplesIsolate,
cpuSamples: CpuSamples.parse(goldenCpuSamplesJson)!..functions = null,
),
completes,
);
});

test('to json defaults packageUri to resolvedUrl', () {
const id = '140357727781376-12';

Expand Down