Skip to content

Run dcm check-unused-code on each PR to find unused code.#9908

Merged
kenzieschmoll merged 8 commits into
flutter:masterfrom
kenzieschmoll:unused-code-dcm
Jul 22, 2026
Merged

Run dcm check-unused-code on each PR to find unused code.#9908
kenzieschmoll merged 8 commits into
flutter:masterfrom
kenzieschmoll:unused-code-dcm

Conversation

@kenzieschmoll

Copy link
Copy Markdown
Member

Runs dcm check-unused-code on each PR. This will help automate codebase health standards are checked on each PR.

I have intentionally excluded several directories and will work through those in separate PRs.

Work towards #9906.

@kenzieschmoll
kenzieschmoll requested a review from a team as a code owner July 21, 2026 23:13
@kenzieschmoll
kenzieschmoll requested review from srawlins and removed request for a team July 21, 2026 23:13
@kenzieschmoll kenzieschmoll changed the title Unused code dcm Run dcm check-unused-code on each PR to find unused code. Jul 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds exclusions for unused-code in analysis_options.yaml and suppresses false positive warnings in packages/devtools_app/lib/src/app.dart using ignore: unused-code comments. The reviewer suggests refactoring the usage of _AlternateCheckedModeBanner from an assert block to a kDebugMode check, which would eliminate the false positive entirely and avoid the need for suppression comments.

Comment thread packages/devtools_app/lib/src/app.dart
@kenzieschmoll
kenzieschmoll merged commit 1c7e423 into flutter:master Jul 22, 2026
92 of 95 checks passed
@kenzieschmoll
kenzieschmoll deleted the unused-code-dcm branch July 22, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants