Fix issue with compare_benchmarks.dart script - #9954
Merged
Conversation
kenzieschmoll
requested review from
bkonyi and
johnpryan
and removed request for
a team
August 10, 2026 20:40
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes an unused import of devtools_app/src/shared/primitives/utils.dart from compare_benchmarks.dart and introduces a prettyPrintJson utility function in utils.dart within the benchmark scripts. I have no feedback to provide.
srawlins
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent change to use a
prettyPrintJsonhelper fromdevtools_appcaused errors when running the benchmark comparison scripts sincedevtools_appintroduces an unnecessary flutter dependency for this script.This PR removes the import from
devtools_appto inline the helper in the benchmark utils.