This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use a duration event for "FlutterEngineMainEnter" #2703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll use it as time 0.
| Dart_TimelineEvent("FlutterEngineMainEnter", // label | ||
| blink::engine_main_enter_ts, // timestamp0 | ||
| blink::engine_main_enter_ts, // timestamp1_or_async_id | ||
| Dart_Timeline_Event_Duration, // event type |
There was a problem hiding this comment.
does this mean that on the timeline chart it's going to draw a huge bar the length of the profile?
There was a problem hiding this comment.
No, a tiny sliver on left.
Cool. In that case, LGTM! |
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
New commits: git log --format="%C(auto) %h %s" 900e796..4ca4767 4ca4767 Added a dart pub outdated --transitive option (flutter#2731) 6b145bd Deprecate --server argument to `pub publish` and `pub uploader`. (flutter#2697) 7737023 don't warn if previous prerelease was null safe (flutter#2730) 62f9283 Improve outdated --mode=null-safety (flutter#2724) cc589ec Change message for no Latest resolution (flutter#2729) 656803e Require sdk constraint (flutter#2718) 8309d87 Added test that dev_dependency does not trigger null-safety warnings when publishing (flutter#2727) 332ea04 Remove warning about mixed mode. (flutter#2723) a98a1f2 Simplify null-safety analysis in `pub outdated --mode=null-safety` (flutter#2721) 5fba201 Outdated null safety implies prereleases (flutter#2722) fb9ec4a Fixed bug in yaml_edit (flutter#2703) Change-Id: I22a084aee06542e04a272269fb0134f0ac62f779 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170690 Commit-Queue: Sigurd Meldgaard <sigurdm@google.com> Reviewed-by: Michael Thomsen <mit@google.com> Reviewed-by: Jonas Jensen <jonasfj@google.com>
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a duration event for "FlutterEngineMainEnter" so about:tracing will use it as time 0.