Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Codesign pub package vended service dylibs after copying them to the application bundle. #2727

Merged
merged 1 commit into from
May 31, 2016
Merged

Codesign pub package vended service dylibs after copying them to the application bundle. #2727

merged 1 commit into from
May 31, 2016

Conversation

chinmaygarde
Copy link
Member

No description provided.

@chinmaygarde
Copy link
Member Author

Xcode wrecked the formatting. The formatted script for reference https://gist.github.com/chinmaygarde/e691e0b256588a1ae885276b26899f5b

@chinmaygarde
Copy link
Member Author

Fixes flutter/flutter#4226

@abarth
Copy link
Contributor

abarth commented May 31, 2016

Can we put this script in packages/flutter_tools/bin so that we can maintain it even when we don't control the Xcode project?

@chinmaygarde
Copy link
Member Author

chinmaygarde commented May 31, 2016 •
edited
Loading

The EXPANDED_CODE_SIGN_IDENTITY variable is one that is automatically set by Xcode during its build process. So I am pretty sure we can't separate this step out of Xcode.

@chinmaygarde
Copy link
Member Author

We could export it out and read it from ENV in the script though. Not sure if that is cleaner though.

@abarth
Copy link
Contributor

abarth commented May 31, 2016

Xcode doesn't set it in the env already? It lets it locally and then sources the script?

@chinmaygarde
Copy link
Member Author

I am thinking of moving out BuildFlutterApp as well as this script out into flutter_tools in a single patch. For some reason I thought I was already out of the Xcode project.

@abarth
Copy link
Contributor

abarth commented May 31, 2016

Yeah, I haven't landed that patch yet.

@abarth
Copy link
Contributor

abarth commented May 31, 2016

LGTM to land as-is.

@chinmaygarde chinmaygarde merged commit 85e2ce2 into flutter:master May 31, 2016
abarth added a commit to abarth/engine that referenced this pull request Jun 1, 2016
@abarth
Revert "Codesign pub package vended service dylibs after copying them…
2cb5718 
… to the application bundle. (flutter#2727)"

This reverts commit 85e2ce2.

This patch breaks the flutter build bots.
@abarth abarth mentioned this pull request Jun 1, 2016
Merged
abarth added a commit that referenced this pull request Jun 1, 2016
@abarth
Revert "Codesign pub package vended service dylibs after copying them…
8a4dba9 
… to the application bundle. (#2727)" (#2730)

This reverts commit 85e2ce2.

This patch breaks the flutter build bots.
rhencke pushed a commit to rhencke/engine that referenced this pull request Dec 20, 2020
@sigurdm
Bump pub
9d132eb 
New commits:

git log --format="%C(auto) %h %s" 900e796..4ca4767
 4ca4767 Added a dart pub outdated --transitive option (flutter#2731)
 6b145bd Deprecate --server argument to `pub publish` and `pub uploader`. (flutter#2697)
 7737023 don't warn if previous prerelease was null safe (flutter#2730)
 62f9283 Improve outdated --mode=null-safety (flutter#2724)
 cc589ec Change message for no Latest resolution (flutter#2729)
 656803e Require sdk constraint (flutter#2718)
 8309d87 Added test that dev_dependency does not trigger null-safety warnings when publishing (flutter#2727)
 332ea04 Remove warning about mixed mode. (flutter#2723)
 a98a1f2 Simplify null-safety analysis in `pub outdated --mode=null-safety` (flutter#2721)
 5fba201 Outdated null safety implies prereleases (flutter#2722)
 fb9ec4a Fixed bug in yaml_edit (flutter#2703)

Change-Id: I22a084aee06542e04a272269fb0134f0ac62f779
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170690
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
rhencke pushed a commit to rhencke/engine that referenced this pull request Dec 20, 2020
@jonasfj
Added test that dev_dependency does not trigger null-safety warnings …
8309d87 
…when publishing (flutter#2727)

* Added test that dev_dependency does not trigger null-safety warnings when publishing

* Fix bug on master
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chinmaygarde @abarth